2021-08-24 18:39:21

by Kari Argillander

Subject: [PATCH v4 1/3] fs/ntfs3: Restyle comment block in ni_parse_reparse()

First of this fix one none utf8 char in this comment block. Maybe
this happened because error in filesystem ;)

Also this block was hard to read because long lines so make it max 80
long. And while we doing this stuff make little better grammer.

Signed-off-by: Kari Argillander <[email protected]>
---
fs/ntfs3/frecord.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
index c3121bf9c62f..e94d830b2f4a 100644
--- a/fs/ntfs3/frecord.c
+++ b/fs/ntfs3/frecord.c
@@ -1782,14 +1782,18 @@ enum REPARSE_SIGN ni_parse_reparse(struct ntfs_inode *ni, struct ATTRIB *attr,
break;
case IO_REPARSE_TAG_COMPRESS:
/*
- * WOF - Windows Overlay Filter - used to compress files with lzx/xpress
- * Unlike native NTFS file compression, the Windows Overlay Filter supports
- * only read operations. This means that it doesn?t need to sector-align each
- * compressed chunk, so the compressed data can be packed more tightly together.
- * If you open the file for writing, the Windows Overlay Filter just decompresses
+ * WOF - Windows Overlay Filter - Used to compress files with
+ * LZX/Xpress.
+ *
+ * Unlike native NTFS file compression, the Windows
+ * Overlay Filter supports only read operations. This means
+ * that it doesn't need to sector-align each compressed chunk,
+ * so the compressed data can be packed more tightly together.
+ * If you open the file for writing, the WOF just decompresses
* the entire file, turning it back into a plain file.
*
- * ntfs3 driver decompresses the entire file only on write or change size requests
+ * Ntfs3 driver decompresses the entire file only on write or
+ * change size requests.
*/

cmpr = &rp->CompressReparseBuffer;
--
2.25.1

2021-08-25 06:35:54

by Christoph Hellwig

Subject: Re: [PATCH v4 1/3] fs/ntfs3: Restyle comment block in ni_parse_reparse()

On Tue, Aug 24, 2021 at 09:37:06PM +0300, Kari Argillander wrote:
> First of this fix one none utf8 char in this comment block. Maybe
> this happened because error in filesystem ;)
>
> Also this block was hard to read because long lines so make it max 80
> long. And while we doing this stuff make little better grammer.
>
> Signed-off-by: Kari Argillander <[email protected]>

Looks good,

Reviewed-by: Christoph Hellwig <[email protected]>