2021-08-25 07:08:48

by Tang Bin

Subject: [PATCH v2] can: mscan: mpc5xxx_can: Remove useless BUG_ON()

In the function mpc5xxx_can_probe(), the variable 'data'
has already been determined in the above code, so the
BUG_ON() in this place is useless, remove it.

Signed-off-by: Tang Bin <[email protected]>
---
Changes to v1
- Fix the commit message for typo
---
drivers/net/can/mscan/mpc5xxx_can.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan/mpc5xxx_can.c
index 3b7465acd..35892c1ef 100644
--- a/drivers/net/can/mscan/mpc5xxx_can.c
+++ b/drivers/net/can/mscan/mpc5xxx_can.c
@@ -317,7 +317,6 @@ static int mpc5xxx_can_probe(struct platform_device *ofdev)

clock_name = of_get_property(np, "fsl,mscan-clock-source", NULL);

- BUG_ON(!data);
priv->type = data->type;
priv->can.clock.freq = data->get_clock(ofdev, clock_name,
&mscan_clksrc);
--
2.20.1.windows.1

2021-08-25 10:33:22

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v2] can: mscan: mpc5xxx_can: Remove useless BUG_ON()

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Wed, 25 Aug 2021 15:07:52 +0800 you wrote:
> In the function mpc5xxx_can_probe(), the variable 'data'
> has already been determined in the above code, so the
> BUG_ON() in this place is useless, remove it.
>
> Signed-off-by: Tang Bin <[email protected]>
> ---
> Changes to v1
> - Fix the commit message for typo
>
> [...]

Here is the summary with links:
- [v2] can: mscan: mpc5xxx_can: Remove useless BUG_ON()
https://git.kernel.org/netdev/net-next/c/cbe8cd7d83e2

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html