2021-08-25 22:20:34

by Drew Fustini

Subject: [PATCH] ARM: dts: am335x-pocketbeagle: switch to pinconf-single

Switch the compatible for the am33xx_pinmux pin controller node from
pinctrl-single to pinconf-single. The only change between these two
compatibles is that PCS_HAS_PINCONF will be true. This then allows
pinconf properties to be utilized.

The purpose of this change is to allow the PocketBeagle to use:

pinctrl-single,bias-pullup
pinctrl-single,bias-pulldown

This dts already defines these properites for gpio pins in the default
pinctrl state but it has no effect unless PCS_HAS_PINCONF is set.

The bias properties can then be modified on the corresponding gpio lines
through the gpiod uapi. The mapping between the pins and gpio lines is
defined by gpio-ranges under the gpio controller nodes in am33xx-l4.dtsi

Signed-off-by: Drew Fustini <[email protected]>
---
arch/arm/boot/dts/am335x-pocketbeagle.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/am335x-pocketbeagle.dts b/arch/arm/boot/dts/am335x-pocketbeagle.dts
index 209cdd17dc1e..5e415d8ffdd8 100644
--- a/arch/arm/boot/dts/am335x-pocketbeagle.dts
+++ b/arch/arm/boot/dts/am335x-pocketbeagle.dts
@@ -205,6 +205,7 @@ &gpio3 {

&am33xx_pinmux {

+ compatible = "pinconf-single";
pinctrl-names = "default";

pinctrl-0 = < &P2_03_gpio &P1_34_gpio &P2_19_gpio &P2_24_gpio
--
2.27.0

2021-10-06 07:33:21

by Tony Lindgren

Subject: Re: [PATCH] ARM: dts: am335x-pocketbeagle: switch to pinconf-single

* Drew Fustini <[email protected]> [210826 01:20]:
> Switch the compatible for the am33xx_pinmux pin controller node from
> pinctrl-single to pinconf-single. The only change between these two
> compatibles is that PCS_HAS_PINCONF will be true. This then allows
> pinconf properties to be utilized.
>
> The purpose of this change is to allow the PocketBeagle to use:
>
> pinctrl-single,bias-pullup
> pinctrl-single,bias-pulldown
>
> This dts already defines these properites for gpio pins in the default
> pinctrl state but it has no effect unless PCS_HAS_PINCONF is set.
>
> The bias properties can then be modified on the corresponding gpio lines
> through the gpiod uapi. The mapping between the pins and gpio lines is
> defined by gpio-ranges under the gpio controller nodes in am33xx-l4.dtsi

Thanks applying into omap-for-v5.16/dt.

Tony