2021-08-27 02:28:40

by Jianjun Wang (王建军)

Subject: [PATCH v2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195

MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192.

Signed-off-by: Jianjun Wang <[email protected]>
---
Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
index 742206dbd965..93e09c3029b7 100644
--- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
+++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
@@ -48,7 +48,9 @@ allOf:

properties:
compatible:
- const: mediatek,mt8192-pcie
+ enum:
+ - mediatek,mt8192-pcie
+ - mediatek,mt8195-pcie

reg:
maxItems: 1
--
2.18.0

2021-08-30 16:07:30

by Rob Herring

Subject: Re: [PATCH v2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195

On Thu, Aug 26, 2021 at 9:26 PM Jianjun Wang <[email protected]> wrote:
>
> MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192.
>
> Signed-off-by: Jianjun Wang <[email protected]>
> ---
> Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> index 742206dbd965..93e09c3029b7 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> @@ -48,7 +48,9 @@ allOf:
>
> properties:
> compatible:
> - const: mediatek,mt8192-pcie
> + enum:
> + - mediatek,mt8192-pcie
> + - mediatek,mt8195-pcie

I thought you wanted to support 8192 as the fallback:

compatible = "mediatek,mt8195-pcie", "mediatek,mt8192-pcie";

The above schema doesn't allow this.

Rob

2021-09-02 02:09:34

by Jianjun Wang (王建军)

Subject: Re: [PATCH v2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195

On Mon, 2021-08-30 at 11:02 -0500, Rob Herring wrote:
> On Thu, Aug 26, 2021 at 9:26 PM Jianjun Wang <
> [email protected]> wrote:
> >
> > MT8195 is an ARM platform SoC which has the same PCIe IP with
> > MT8192.
> >
> > Signed-off-by: Jianjun Wang <[email protected]>
> > ---
> > Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4
> > +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-
> > gen3.yaml
> > index 742206dbd965..93e09c3029b7 100644
> > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml
> > @@ -48,7 +48,9 @@ allOf:
> >
> > properties:
> > compatible:
> > - const: mediatek,mt8192-pcie
> > + enum:
> > + - mediatek,mt8192-pcie
> > + - mediatek,mt8195-pcie
>
> I thought you wanted to support 8192 as the fallback:
>
> compatible = "mediatek,mt8195-pcie", "mediatek,mt8192-pcie";
>
> The above schema doesn't allow this.
>
> Rob

Hi Rob,

Yes, I want this fallback to support MT8195, but there are some un-
documented warnings if I don't add its compatible string to the yaml
file.

Do you have any suggestions in this case?

Thanks.