2021-08-29 05:38:58

by Jiwon Kim

[permalink] [raw]
Subject: [PATCH] ipv6: add spaces for accept_ra_min_hop_limit

From: Jiwon Kim <[email protected]>

The checkpatch reported
ERROR: spaces required around that '=' (ctx:VxW)
from the net/ipv6/addrconf.c.

So, spaces are added for accept_ra_min_hop_limit.

Signed-off-by: Jiwon Kim <[email protected]>
---
net/ipv6/addrconf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 17756f3ed33b..ce71480a92d9 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -208,7 +208,7 @@ static struct ipv6_devconf ipv6_devconf __read_mostly = {
.accept_ra_defrtr = 1,
.ra_defrtr_metric = IP6_RT_PRIO_USER,
.accept_ra_from_local = 0,
- .accept_ra_min_hop_limit= 1,
+ .accept_ra_min_hop_limit = 1,
.accept_ra_pinfo = 1,
#ifdef CONFIG_IPV6_ROUTER_PREF
.accept_ra_rtr_pref = 1,
@@ -267,7 +267,7 @@ static struct ipv6_devconf ipv6_devconf_dflt __read_mostly = {
.accept_ra_defrtr = 1,
.ra_defrtr_metric = IP6_RT_PRIO_USER,
.accept_ra_from_local = 0,
- .accept_ra_min_hop_limit= 1,
+ .accept_ra_min_hop_limit = 1,
.accept_ra_pinfo = 1,
#ifdef CONFIG_IPV6_ROUTER_PREF
.accept_ra_rtr_pref = 1,
--
2.25.1


2021-08-29 17:06:21

by David Miller

[permalink] [raw]
Subject: Re: [PATCH] ipv6: add spaces for accept_ra_min_hop_limit

From: [email protected]
Date: Sun, 29 Aug 2021 14:35:44 +0900

> From: Jiwon Kim <[email protected]>
>
> The checkpatch reported
> ERROR: spaces required around that '=' (ctx:VxW)
> from the net/ipv6/addrconf.c.
>
> So, spaces are added for accept_ra_min_hop_limit.
>
> Signed-off-by: Jiwon Kim <[email protected]>

Please don't do this it breaks the vertical alignbment of the right hand side of
the assignments.

Thanks.