2021-08-29 20:00:41

by Artur Rojek

Subject: [PATCH] dmaengine: jz4780: Set max number of SGs per burst

Total amount of SG list entries executed in a single burst is limited by
the number of available DMA descriptors.
This information is useful for device drivers utilizing this DMA engine.

Signed-off-by: Artur Rojek <[email protected]>
---
drivers/dma/dma-jz4780.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
index ebee94dbd630..96701dedcac8 100644
--- a/drivers/dma/dma-jz4780.c
+++ b/drivers/dma/dma-jz4780.c
@@ -915,6 +915,7 @@ static int jz4780_dma_probe(struct platform_device *pdev)
dd->dst_addr_widths = JZ_DMA_BUSWIDTHS;
dd->directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
dd->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
+ dd->max_sg_burst = JZ_DMA_MAX_DESC;

/*
* Enable DMA controller, mark all channels as not programmable.
--
2.33.0

2021-08-30 09:51:04

by Paul Cercueil

Subject: Re: [PATCH] dmaengine: jz4780: Set max number of SGs per burst

Hi,

Le dim., ao?t 29 2021 at 21:58:05 +0200, Artur Rojek
<[email protected]> a ?crit :
> Total amount of SG list entries executed in a single burst is limited
> by
> the number of available DMA descriptors.
> This information is useful for device drivers utilizing this DMA
> engine.
>
> Signed-off-by: Artur Rojek <[email protected]>

Acked-by: Paul Cercueil <[email protected]>

Cheers,
-Paul

> ---
> drivers/dma/dma-jz4780.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
> index ebee94dbd630..96701dedcac8 100644
> --- a/drivers/dma/dma-jz4780.c
> +++ b/drivers/dma/dma-jz4780.c
> @@ -915,6 +915,7 @@ static int jz4780_dma_probe(struct
> platform_device *pdev)
> dd->dst_addr_widths = JZ_DMA_BUSWIDTHS;
> dd->directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
> dd->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
> + dd->max_sg_burst = JZ_DMA_MAX_DESC;
>
> /*
> * Enable DMA controller, mark all channels as not programmable.
> --
> 2.33.0
>

2021-10-11 16:37:17

by Paul Cercueil

Subject: Re: [PATCH] dmaengine: jz4780: Set max number of SGs per burst

Hi Vinod,

Le lun., ao?t 30 2021 at 10:48:52 +0100, Paul Cercueil
<[email protected]> a ?crit :
> Hi,
>
> Le dim., ao?t 29 2021 at 21:58:05 +0200, Artur Rojek
> <[email protected]> a ?crit :
>> Total amount of SG list entries executed in a single burst is
>> limited by
>> the number of available DMA descriptors.
>> This information is useful for device drivers utilizing this DMA
>> engine.
>>
>> Signed-off-by: Artur Rojek <[email protected]>
>
> Acked-by: Paul Cercueil <[email protected]>

Feedback on this?

Cheers,
-Paul

>> ---
>> drivers/dma/dma-jz4780.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
>> index ebee94dbd630..96701dedcac8 100644
>> --- a/drivers/dma/dma-jz4780.c
>> +++ b/drivers/dma/dma-jz4780.c
>> @@ -915,6 +915,7 @@ static int jz4780_dma_probe(struct
>> platform_device *pdev)
>> dd->dst_addr_widths = JZ_DMA_BUSWIDTHS;
>> dd->directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
>> dd->residue_granularity = DMA_RESIDUE_GRANULARITY_BURST;
>> + dd->max_sg_burst = JZ_DMA_MAX_DESC;
>>
>> /*
>> * Enable DMA controller, mark all channels as not programmable.
>> --
>> 2.33.0
>>
>

2021-10-18 06:42:07

by Vinod Koul

Subject: Re: [PATCH] dmaengine: jz4780: Set max number of SGs per burst

On 29-08-21, 21:58, Artur Rojek wrote:
> Total amount of SG list entries executed in a single burst is limited by
> the number of available DMA descriptors.
> This information is useful for device drivers utilizing this DMA engine.

Applied, thanks

--
~Vinod