2021-08-30 10:49:09

by Alejandro Tafalla

Subject: [PATCH v2 1/2] ASoC: max98927: Handle reset gpio when probing i2c

Drive the reset gpio if defined in the DTS node.

Signed-off-by: Alejandro Tafalla <[email protected]>
---
sound/soc/codecs/max98927.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/sound/soc/codecs/max98927.c b/sound/soc/codecs/max98927.c
index 8b206ee77709..84a159de4b26 100644
--- a/sound/soc/codecs/max98927.c
+++ b/sound/soc/codecs/max98927.c
@@ -868,6 +868,7 @@ static int max98927_i2c_probe(struct i2c_client *i2c,
int ret = 0, value;
int reg = 0;
struct max98927_priv *max98927 = NULL;
+ struct gpio_desc *reset_gpio;

max98927 = devm_kzalloc(&i2c->dev,
sizeof(*max98927), GFP_KERNEL);
@@ -898,6 +899,20 @@ static int max98927_i2c_probe(struct i2c_client *i2c,
return ret;
}

+ reset_gpio
+ = devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD_OUT_LOW);
+ if (IS_ERR(reset_gpio)) {
+ ret = PTR_ERR(reset_gpio);
+ return dev_err_probe(&i2c->dev, ret,
+ "failed to request GPIO reset pin");
+ }
+
+ if (reset_gpio) {
+ usleep_range(8000, 10000);
+ gpiod_set_value_cansleep(reset_gpio, 1);
+ usleep_range(1000, 5000);
+ }
+
/* Check Revision ID */
ret = regmap_read(max98927->regmap,
MAX98927_R01FF_REV_ID, &reg);
--
2.32.0

2021-08-30 10:59:12

by Andy Shevchenko

Subject: Re: [PATCH v2 1/2] ASoC: max98927: Handle reset gpio when probing i2c

On Mon, Aug 30, 2021 at 1:48 PM Alejandro Tafalla <[email protected]> wrote:
>
> Drive the reset gpio if defined in the DTS node.

...

> + reset_gpio
> + = devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD_OUT_LOW);

A bit of a strange indentation, shouldn't it be one line?

> + if (IS_ERR(reset_gpio)) {

> + ret = PTR_ERR(reset_gpio);
> + return dev_err_probe(&i2c->dev, ret,
> + "failed to request GPIO reset pin");

It simply as

return dev_err_probe(&i2c->dev, PTR_ERR(reset_gpio),
"failed to request GPIO reset pin");

> + }

--
With Best Regards,
Andy Shevchenko

2021-09-01 17:08:55

by Alejandro Tafalla

Subject: Re: [PATCH v2 1/2] ASoC: max98927: Handle reset gpio when probing i2c

On lunes, 30 de agosto de 2021 12:56:23 (CEST) Andy Shevchenko wrote:
> It simply as
>
> return dev_err_probe(&i2c->dev, PTR_ERR(reset_gpio),
> "failed to request GPIO reset pin");
>
> > + }
Alright, I'll make that change. Thank you.