2021-08-30 14:57:22

by Justin He

Subject: [PATCH] KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu_page

After reverting and restoring the fast tlb invalidation patch series,
the mmio_cached is not removed. Hence a unused field is left in
kvm_mmu_page.

Cc: Sean Christopherson <[email protected]>
Signed-off-by: Jia He <[email protected]>
---
arch/x86/kvm/mmu/mmu_internal.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/x86/kvm/mmu/mmu_internal.h b/arch/x86/kvm/mmu/mmu_internal.h
index 35567293c1fd..3e6f21c1871a 100644
--- a/arch/x86/kvm/mmu/mmu_internal.h
+++ b/arch/x86/kvm/mmu/mmu_internal.h
@@ -37,7 +37,6 @@ struct kvm_mmu_page {

bool unsync;
u8 mmu_valid_gen;
- bool mmio_cached;
bool lpage_disallowed; /* Can't be replaced by an equiv large page */

/*
--
2.17.1

2021-09-01 20:26:52

by Sean Christopherson

Subject: Re: [PATCH] KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu_page

On Mon, Aug 30, 2021, Jia He wrote:
> After reverting and restoring the fast tlb invalidation patch series,
> the mmio_cached is not removed. Hence a unused field is left in
> kvm_mmu_page.
>
> Cc: Sean Christopherson <[email protected]>
> Signed-off-by: Jia He <[email protected]>

Reviewed-by: Sean Christopherson <[email protected]>

There's also additional cleanup we can do to take advantage of the free byte.
I'll include this patch in a follow-up mini-series to hopefully make life a bit
easier for Paolo.

Thanks!

2021-09-06 10:46:52

by Paolo Bonzini

Subject: Re: [PATCH] KVM: x86/mmu: Remove unused field mmio_cached in struct kvm_mmu_page

On 30/08/21 16:53, Jia He wrote:
> After reverting and restoring the fast tlb invalidation patch series,
> the mmio_cached is not removed. Hence a unused field is left in
> kvm_mmu_page.
>
> Cc: Sean Christopherson <[email protected]>
> Signed-off-by: Jia He <[email protected]>
> ---
> arch/x86/kvm/mmu/mmu_internal.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/mmu/mmu_internal.h b/arch/x86/kvm/mmu/mmu_internal.h
> index 35567293c1fd..3e6f21c1871a 100644
> --- a/arch/x86/kvm/mmu/mmu_internal.h
> +++ b/arch/x86/kvm/mmu/mmu_internal.h
> @@ -37,7 +37,6 @@ struct kvm_mmu_page {
>
> bool unsync;
> u8 mmu_valid_gen;
> - bool mmio_cached;
> bool lpage_disallowed; /* Can't be replaced by an equiv large page */
>
> /*
>

Queued, thanks.

Paolo