2021-08-31 01:26:34

by zhaoxiao

Subject: [PATCH v3] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe()

Change the pr_info to dev_err.

Signed-off-by: zhaoxiao <[email protected]>
---
v3:Remove the redundant blank line.
drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
index 4c9a37dd0d3f..f03f25d9adb0 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c
@@ -54,14 +54,13 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id
bool mdio = false;

np = dev_of_node(&pdev->dev);
-
if (!np) {
- pr_info("dwmac_loongson_pci: No OF node\n");
+ dev_err(&pdev->dev, "dwmac_loongson_pci: No OF node\n");
return -ENODEV;
}

if (!of_device_is_compatible(np, "loongson, pci-gmac")) {
- pr_info("dwmac_loongson_pci: Incompatible OF node\n");
+ dev_err(&pdev->dev, "dwmac_loongson_pci: Incompatible OF node\n");
return -ENODEV;
}

--
2.20.1

2021-08-31 17:12:46

by Jakub Kicinski

Subject: Re: [PATCH v3] stmmac: dwmac-loongson: change the pr_info() to dev_err() in loongson_dwmac_probe()

On Tue, 31 Aug 2021 09:25:23 +0800 zhaoxiao wrote:
> Change the pr_info to dev_err.
>
> Signed-off-by: zhaoxiao <[email protected]>

Your patches seem to not show up on the netdev mailing list.
They do make it to lkml and linux-arm tho, strangely.

Are you seeing any errors when sending them?

Please repost this one and CC [email protected] - let's see
if it gets thru..