2021-08-31 13:58:18

by Cai,Huoqing

Subject: [PATCH] drm/imx: imx-tve: Make use of the helper function devm_platform_ioremap_resource()

Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/gpu/drm/imx/imx-tve.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c
index bc8c3f802a15..2b1fdf2cbbce 100644
--- a/drivers/gpu/drm/imx/imx-tve.c
+++ b/drivers/gpu/drm/imx/imx-tve.c
@@ -526,7 +526,6 @@ static int imx_tve_probe(struct platform_device *pdev)
struct device_node *np = dev->of_node;
struct device_node *ddc_node;
struct imx_tve *tve;
- struct resource *res;
void __iomem *base;
unsigned int val;
int irq;
@@ -568,8 +567,7 @@ static int imx_tve_probe(struct platform_device *pdev)
}
}

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- base = devm_ioremap_resource(dev, res);
+ base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(base))
return PTR_ERR(base);

--
2.25.1

2021-09-01 07:08:42

by Philipp Zabel

Subject: Re: [PATCH] drm/imx: imx-tve: Make use of the helper function devm_platform_ioremap_resource()

Hi Cai,

On Tue, 2021-08-31 at 21:55 +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <[email protected]>

Thank you, applied to imx-drm/next.

regards
Philipp