2021-08-31 07:13:29

by Chanwoo Lee

Subject: [PATCH] scsi: ufs: ufshpb: Remove unused parameters

From: ChanWoo Lee <[email protected]>

Remove unused parameters
* ufshpb_set_hpb_read_to_upiu()
-> struct ufshpb_lu *hpb
-> u32 lpn

Signed-off-by: ChanWoo Lee <[email protected]>
---
drivers/scsi/ufs/ufshpb.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index 02fb51ae8b25..589af5f6b940 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -333,9 +333,8 @@ ufshpb_get_pos_from_lpn(struct ufshpb_lu *hpb, unsigned long lpn, int *rgn_idx,
}

static void
-ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshpb_lu *hpb,
- struct ufshcd_lrb *lrbp, u32 lpn, __be64 ppn,
- u8 transfer_len, int read_id)
+ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp,
+ __be64 ppn, u8 transfer_len, int read_id)
{
unsigned char *cdb = lrbp->cmd->cmnd;
__be64 ppn_tmp = ppn;
@@ -703,8 +702,7 @@ int ufshpb_prep(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
}
}

- ufshpb_set_hpb_read_to_upiu(hba, hpb, lrbp, lpn, ppn, transfer_len,
- read_id);
+ ufshpb_set_hpb_read_to_upiu(hba, lrbp, ppn, transfer_len, read_id);

hpb->stats.hit_cnt++;
return 0;
--
2.29.0

2021-08-31 15:47:37

by Bart Van Assche

Subject: Re: [PATCH] scsi: ufs: ufshpb: Remove unused parameters

On 8/31/21 00:04, Chanwoo Lee wrote:
> From: ChanWoo Lee <[email protected]>
>
> Remove unused parameters
> * ufshpb_set_hpb_read_to_upiu()
> -> struct ufshpb_lu *hpb
> -> u32 lpn

Please use full sentences in the patch description for future patch
submissions. Anyway:

Reviewed-by: Bart Van Assche <[email protected]>

2021-09-01 00:49:14

by Chanwoo Lee

Subject: Re: Re: [PATCH] scsi: ufs: ufshpb: Remove unused parameters

>On 8/31/21 00:04, Chanwoo Lee wrote:
>> From: ChanWoo Lee <[email protected]>
>>
>> Remove unused parameters
>> * ufshpb_set_hpb_read_to_upiu()
>> -> struct ufshpb_lu *hpb
>> -> u32 lpn
>
>Please use full sentences in the patch description for future patch
>submissions. Anyway:
>
>Reviewed-by: Bart Van Assche <[email protected]>

Thank you, I will edit the description and upload it again.//v2