2021-09-01 03:11:43

by Chanwoo Lee

[permalink] [raw]
Subject: [PATCH v3] scsi: ufs: ufshpb: Remove unused parameters

From: ChanWoo Lee <[email protected]>

The following parameters are not used in the function.
So, remove unused parameters.

*func(): ufshpb_set_hpb_read_to_upiu
-> struct ufshpb_lu *hpb
-> u32 lpn

Reviewed-by: Daejun Park <[email protected]>
Reviewed-by: Bart Van Assche <[email protected]>
Signed-off-by: ChanWoo Lee <[email protected]>

---
v2->v3:
* Add tag information.
v1->v2:
* edit description.
---
drivers/scsi/ufs/ufshpb.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index 02fb51ae8b25..589af5f6b940 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -333,9 +333,8 @@ ufshpb_get_pos_from_lpn(struct ufshpb_lu *hpb, unsigned long lpn, int *rgn_idx,
}

static void
-ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshpb_lu *hpb,
- struct ufshcd_lrb *lrbp, u32 lpn, __be64 ppn,
- u8 transfer_len, int read_id)
+ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp,
+ __be64 ppn, u8 transfer_len, int read_id)
{
unsigned char *cdb = lrbp->cmd->cmnd;
__be64 ppn_tmp = ppn;
@@ -703,8 +702,7 @@ int ufshpb_prep(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
}
}

- ufshpb_set_hpb_read_to_upiu(hba, hpb, lrbp, lpn, ppn, transfer_len,
- read_id);
+ ufshpb_set_hpb_read_to_upiu(hba, lrbp, ppn, transfer_len, read_id);

hpb->stats.hit_cnt++;
return 0;
--
2.29.0


2021-09-14 03:47:09

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH v3] scsi: ufs: ufshpb: Remove unused parameters

On Wed, 1 Sep 2021 11:56:17 +0900, Chanwoo Lee wrote:

> From: ChanWoo Lee <[email protected]>
>
> The following parameters are not used in the function.
> So, remove unused parameters.
>
> *func(): ufshpb_set_hpb_read_to_upiu
> -> struct ufshpb_lu *hpb
> -> u32 lpn
>
> [...]

Applied to 5.15/scsi-fixes, thanks!

[1/1] scsi: ufs: ufshpb: Remove unused parameters
https://git.kernel.org/mkp/scsi/c/65ef27f7798b

--
Martin K. Petersen Oracle Linux Engineering