2021-09-02 19:54:08

by Miles Chen

Subject: [PATCH] clk: rockchip: use module_platform_driver_probe

Replace builtin_platform_driver_probe with module_platform_driver_probe
because that rk3399 and rk3568 can be built as kernel modules.

Cc: Stephen Boyd <[email protected]>
Signed-off-by: Miles Chen <[email protected]>
---
drivers/clk/rockchip/clk-rk3399.c | 2 +-
drivers/clk/rockchip/clk-rk3568.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c
index 62a4f2543960..a5169156f1d2 100644
--- a/drivers/clk/rockchip/clk-rk3399.c
+++ b/drivers/clk/rockchip/clk-rk3399.c
@@ -1653,7 +1653,7 @@ static struct platform_driver clk_rk3399_driver = {
.suppress_bind_attrs = true,
},
};
-builtin_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);
+module_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);

MODULE_DESCRIPTION("Rockchip RK3399 Clock Driver");
MODULE_LICENSE("GPL");
diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c
index 75ca855e720d..939e7079c334 100644
--- a/drivers/clk/rockchip/clk-rk3568.c
+++ b/drivers/clk/rockchip/clk-rk3568.c
@@ -1719,7 +1719,7 @@ static struct platform_driver clk_rk3568_driver = {
.suppress_bind_attrs = true,
},
};
-builtin_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);
+module_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);

MODULE_DESCRIPTION("Rockchip RK3568 Clock Driver");
MODULE_LICENSE("GPL");
--
2.18.0

2021-09-03 19:31:36

by Stephen Boyd

Subject: Re: [PATCH] clk: rockchip: use module_platform_driver_probe

Quoting Miles Chen (2021-09-02 00:57:13)
> Replace builtin_platform_driver_probe with module_platform_driver_probe
> because that rk3399 and rk3568 can be built as kernel modules.
>
> Cc: Stephen Boyd <[email protected]>
> Signed-off-by: Miles Chen <[email protected]>

Should it have a fixes tag?

2021-09-03 21:01:33

by Heiko Stuebner

Subject: Re: [PATCH] clk: rockchip: use module_platform_driver_probe

Am Donnerstag, 2. September 2021, 09:57:13 CEST schrieb Miles Chen:
> Replace builtin_platform_driver_probe with module_platform_driver_probe
> because that rk3399 and rk3568 can be built as kernel modules.
>
> Cc: Stephen Boyd <[email protected]>
> Signed-off-by: Miles Chen <[email protected]>

on both rk3399 and rk3568:
Tested-by: Heiko Stuebner <[email protected]>

and also
Reviewed-by: Heiko Stuebner <[email protected]>


Heiko

> ---
> drivers/clk/rockchip/clk-rk3399.c | 2 +-
> drivers/clk/rockchip/clk-rk3568.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c
> index 62a4f2543960..a5169156f1d2 100644
> --- a/drivers/clk/rockchip/clk-rk3399.c
> +++ b/drivers/clk/rockchip/clk-rk3399.c
> @@ -1653,7 +1653,7 @@ static struct platform_driver clk_rk3399_driver = {
> .suppress_bind_attrs = true,
> },
> };
> -builtin_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);
> +module_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);
>
> MODULE_DESCRIPTION("Rockchip RK3399 Clock Driver");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c
> index 75ca855e720d..939e7079c334 100644
> --- a/drivers/clk/rockchip/clk-rk3568.c
> +++ b/drivers/clk/rockchip/clk-rk3568.c
> @@ -1719,7 +1719,7 @@ static struct platform_driver clk_rk3568_driver = {
> .suppress_bind_attrs = true,
> },
> };
> -builtin_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);
> +module_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);
>
> MODULE_DESCRIPTION("Rockchip RK3568 Clock Driver");
> MODULE_LICENSE("GPL");
>

2021-09-04 15:07:02

by Miles Chen

Subject: Re: [PATCH] clk: rockchip: use module_platform_driver_probe

On Fri, 2021-09-03 at 11:32 -0700, Stephen Boyd wrote:
> Quoting Miles Chen (2021-09-02 00:57:13)
> > Replace builtin_platform_driver_probe with
> > module_platform_driver_probe
> > because that rk3399 and rk3568 can be built as kernel modules.
> >
> > Cc: Stephen Boyd <[email protected]>
> > Signed-off-by: Miles Chen <[email protected]>
>
> Should it have a fixes tag?

ok, I will add a fixes tags in the next patch.

2021-09-04 15:12:42

by Miles Chen

Subject: Re: [PATCH] clk: rockchip: use module_platform_driver_probe

On Fri, 2021-09-03 at 22:59 +0200, Heiko Stübner wrote:
> Am Donnerstag, 2. September 2021, 09:57:13 CEST schrieb Miles Chen:
> > Replace builtin_platform_driver_probe with
> > module_platform_driver_probe
> > because that rk3399 and rk3568 can be built as kernel modules.
> >
> > Cc: Stephen Boyd <[email protected]>
> > Signed-off-by: Miles Chen <[email protected]>
>
> on both rk3399 and rk3568:
> Tested-by: Heiko Stuebner <[email protected]>
>
> and also
> Reviewed-by: Heiko Stuebner <[email protected]>
>

thanks for doing the test. I will add your tags in my next patch.
>
> Heiko
>
> > ---
> > drivers/clk/rockchip/clk-rk3399.c | 2 +-
> > drivers/clk/rockchip/clk-rk3568.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/clk/rockchip/clk-rk3399.c
> > b/drivers/clk/rockchip/clk-rk3399.c
> > index 62a4f2543960..a5169156f1d2 100644
> > --- a/drivers/clk/rockchip/clk-rk3399.c
> > +++ b/drivers/clk/rockchip/clk-rk3399.c
> > @@ -1653,7 +1653,7 @@ static struct platform_driver
> > clk_rk3399_driver = {
> > .suppress_bind_attrs = true,
> > },
> > };
> > -builtin_platform_driver_probe(clk_rk3399_driver,
> > clk_rk3399_probe);
> > +module_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);
> >
> > MODULE_DESCRIPTION("Rockchip RK3399 Clock Driver");
> > MODULE_LICENSE("GPL");
> > diff --git a/drivers/clk/rockchip/clk-rk3568.c
> > b/drivers/clk/rockchip/clk-rk3568.c
> > index 75ca855e720d..939e7079c334 100644
> > --- a/drivers/clk/rockchip/clk-rk3568.c
> > +++ b/drivers/clk/rockchip/clk-rk3568.c
> > @@ -1719,7 +1719,7 @@ static struct platform_driver
> > clk_rk3568_driver = {
> > .suppress_bind_attrs = true,
> > },
> > };
> > -builtin_platform_driver_probe(clk_rk3568_driver,
> > clk_rk3568_probe);
> > +module_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);
> >
> > MODULE_DESCRIPTION("Rockchip RK3568 Clock Driver");
> > MODULE_LICENSE("GPL");
> >
>
>
>
>