2021-09-02 08:43:42

by Li Zhijian

Subject: [PATCH] selftests/gpio: Fix gpio compiling error

[root@iaas-rpma gpio]# make
gcc gpio-mockup-cdev.c -o /home/lizhijian/linux/tools/testing/selftests/gpio/gpio-mockup-cdev
gpio-mockup-cdev.c: In function ‘request_line_v2’:
gpio-mockup-cdev.c:24:30: error: storage size of ‘req’ isn’t known
24 | struct gpio_v2_line_request req;
| ^~~
gpio-mockup-cdev.c:32:14: error: ‘GPIO_V2_LINE_FLAG_OUTPUT’ undeclared (first use in this function); did you mean ‘GPIOLINE_FLAG_IS_OUT’?
32 | if (flags & GPIO_V2_LINE_FLAG_OUTPUT) {
| ^~~~~~~~~~~~~~~~~~~~~~~~

Search headers from linux tree like others, such as sched

CC: Philip Li <[email protected]>
Reported-by: kernel test robot <[email protected]>
Signed-off-by: Li Zhijian <[email protected]>
---
tools/testing/selftests/gpio/Makefile | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile
index 39f2bbe8dd3d..42ea7d2aa844 100644
--- a/tools/testing/selftests/gpio/Makefile
+++ b/tools/testing/selftests/gpio/Makefile
@@ -3,5 +3,6 @@
TEST_PROGS := gpio-mockup.sh
TEST_FILES := gpio-mockup-sysfs.sh
TEST_GEN_PROGS_EXTENDED := gpio-mockup-cdev
+CFLAGS += -I../../../../usr/include

include ../lib.mk
--
2.31.1

2021-09-02 09:50:12

by Philip Li

Subject: Re: [PATCH] selftests/gpio: Fix gpio compiling error

On Thu, Sep 02, 2021 at 05:39:18PM +0800, Philip Li wrote:
> applied
sorry, reply the wrong mail, kindly ignore

> On Thu, Sep 02, 2021 at 04:46:35PM +0800, Li Zhijian wrote:
> > [root@iaas-rpma gpio]# make
> > gcc gpio-mockup-cdev.c -o /home/lizhijian/linux/tools/testing/selftests/gpio/gpio-mockup-cdev
> > gpio-mockup-cdev.c: In function ‘request_line_v2’:
> > gpio-mockup-cdev.c:24:30: error: storage size of ‘req’ isn’t known
> > 24 | struct gpio_v2_line_request req;
> > | ^~~
> > gpio-mockup-cdev.c:32:14: error: ‘GPIO_V2_LINE_FLAG_OUTPUT’ undeclared (first use in this function); did you mean ‘GPIOLINE_FLAG_IS_OUT’?
> > 32 | if (flags & GPIO_V2_LINE_FLAG_OUTPUT) {
> > | ^~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Search headers from linux tree like others, such as sched
> >
> > CC: Philip Li <[email protected]>
> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: Li Zhijian <[email protected]>
> > ---
> > tools/testing/selftests/gpio/Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile
> > index 39f2bbe8dd3d..42ea7d2aa844 100644
> > --- a/tools/testing/selftests/gpio/Makefile
> > +++ b/tools/testing/selftests/gpio/Makefile
> > @@ -3,5 +3,6 @@
> > TEST_PROGS := gpio-mockup.sh
> > TEST_FILES := gpio-mockup-sysfs.sh
> > TEST_GEN_PROGS_EXTENDED := gpio-mockup-cdev
> > +CFLAGS += -I../../../../usr/include
> >
> > include ../lib.mk
> > --
> > 2.31.1
> >
> >
> >

2021-09-02 10:05:55

by Philip Li

Subject: Re: [PATCH] selftests/gpio: Fix gpio compiling error

applied
On Thu, Sep 02, 2021 at 04:46:35PM +0800, Li Zhijian wrote:
> [root@iaas-rpma gpio]# make
> gcc gpio-mockup-cdev.c -o /home/lizhijian/linux/tools/testing/selftests/gpio/gpio-mockup-cdev
> gpio-mockup-cdev.c: In function ‘request_line_v2’:
> gpio-mockup-cdev.c:24:30: error: storage size of ‘req’ isn’t known
> 24 | struct gpio_v2_line_request req;
> | ^~~
> gpio-mockup-cdev.c:32:14: error: ‘GPIO_V2_LINE_FLAG_OUTPUT’ undeclared (first use in this function); did you mean ‘GPIOLINE_FLAG_IS_OUT’?
> 32 | if (flags & GPIO_V2_LINE_FLAG_OUTPUT) {
> | ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Search headers from linux tree like others, such as sched
>
> CC: Philip Li <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Li Zhijian <[email protected]>
> ---
> tools/testing/selftests/gpio/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile
> index 39f2bbe8dd3d..42ea7d2aa844 100644
> --- a/tools/testing/selftests/gpio/Makefile
> +++ b/tools/testing/selftests/gpio/Makefile
> @@ -3,5 +3,6 @@
> TEST_PROGS := gpio-mockup.sh
> TEST_FILES := gpio-mockup-sysfs.sh
> TEST_GEN_PROGS_EXTENDED := gpio-mockup-cdev
> +CFLAGS += -I../../../../usr/include
>
> include ../lib.mk
> --
> 2.31.1
>
>
>

2021-09-03 01:19:31

by Shuah Khan

Subject: Re: [PATCH] selftests/gpio: Fix gpio compiling error

On 9/2/21 2:46 AM, Li Zhijian wrote:

I like to see the reason for this compile error followed by how
it is fixed.

> [root@iaas-rpma gpio]# make
> gcc gpio-mockup-cdev.c -o /home/lizhijian/linux/tools/testing/selftests/gpio/gpio-mockup-cdev
> gpio-mockup-cdev.c: In function ‘request_line_v2’:
> gpio-mockup-cdev.c:24:30: error: storage size of ‘req’ isn’t known
> 24 | struct gpio_v2_line_request req;
> | ^~~
> gpio-mockup-cdev.c:32:14: error: ‘GPIO_V2_LINE_FLAG_OUTPUT’ undeclared (first use in this function); did you mean ‘GPIOLINE_FLAG_IS_OUT’?
> 32 | if (flags & GPIO_V2_LINE_FLAG_OUTPUT) {
> | ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Search headers from linux tree like others, such as sched


>
> CC: Philip Li <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Li Zhijian <[email protected]>
> ---
> tools/testing/selftests/gpio/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/gpio/Makefile b/tools/testing/selftests/gpio/Makefile
> index 39f2bbe8dd3d..42ea7d2aa844 100644
> --- a/tools/testing/selftests/gpio/Makefile
> +++ b/tools/testing/selftests/gpio/Makefile
> @@ -3,5 +3,6 @@
> TEST_PROGS := gpio-mockup.sh
> TEST_FILES := gpio-mockup-sysfs.sh
> TEST_GEN_PROGS_EXTENDED := gpio-mockup-cdev
> +CFLAGS += -I../../../../usr/include
>
> include ../lib.mk
>

thanks,
-- Shuah