2021-09-02 23:23:52

by Eugen Hristev

Subject: [PATCH] ARM: dts: at91: sama5d2_som1_ek: disable ISC node by default

Without a sensor node, the ISC will simply fail to probe, as the
corresponding port node is missing.
It is then logical to disable the node in the devicetree.
If we add a port with a connection to a sensor endpoint, ISC can be enabled.

Signed-off-by: Eugen Hristev <[email protected]>
---
arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
index 614999dcb990..cd4672501add 100644
--- a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
+++ b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
@@ -71,7 +71,6 @@ apb {
isc: isc@f0008000 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_isc_base &pinctrl_isc_data_8bit &pinctrl_isc_data_9_10 &pinctrl_isc_data_11_12>;
- status = "okay";
};

qspi1: spi@f0024000 {
--
2.25.1

2021-09-14 15:05:03

by Nicolas Ferre

Subject: Re: [PATCH] ARM: dts: at91: sama5d2_som1_ek: disable ISC node by default

On 02/09/2021 at 14:13, Eugen Hristev wrote:
> Without a sensor node, the ISC will simply fail to probe, as the
> corresponding port node is missing.
> It is then logical to disable the node in the devicetree.
> If we add a port with a connection to a sensor endpoint, ISC can be enabled.
>
> Signed-off-by: Eugen Hristev <[email protected]>

Makes sense:
Acked-by: Nicolas Ferre <[email protected]>

And queued for at91-fixes in 5.15 as there is no point continuing to
have a failing probe on this board.

Thanks, best regards,
Nicolas

> ---
> arch/arm/boot/dts/at91-sama5d27_som1_ek.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
> index 614999dcb990..cd4672501add 100644
> --- a/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
> +++ b/arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
> @@ -71,7 +71,6 @@ apb {
> isc: isc@f0008000 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_isc_base &pinctrl_isc_data_8bit &pinctrl_isc_data_9_10 &pinctrl_isc_data_11_12>;
> - status = "okay";
> };
>
> qspi1: spi@f0024000 {
>


--
Nicolas Ferre