2021-09-01 21:16:57

by Raghavendra Rao Ananta

Subject: [PATCH v3 06/12] KVM: arm64: selftests: Add support to disable and enable local IRQs

Add functions local_irq_enable() and local_irq_disable() to
enable and disable the IRQs from the guest, respectively.

Signed-off-by: Raghavendra Rao Ananta <[email protected]>
---
.../testing/selftests/kvm/include/aarch64/processor.h | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/tools/testing/selftests/kvm/include/aarch64/processor.h b/tools/testing/selftests/kvm/include/aarch64/processor.h
index 78df059dc974..c35bb7b8e870 100644
--- a/tools/testing/selftests/kvm/include/aarch64/processor.h
+++ b/tools/testing/selftests/kvm/include/aarch64/processor.h
@@ -241,4 +241,14 @@ static __always_inline u32 __raw_readl(const volatile void *addr)
#define writel(v,c) ({ __iowmb(); writel_relaxed((v),(c));})
#define readl(c) ({ u32 __v = readl_relaxed(c); __iormb(__v); __v; })

+static inline void local_irq_enable(void)
+{
+ asm volatile("msr daifclr, #3" : : : "memory");
+}
+
+static inline void local_irq_disable(void)
+{
+ asm volatile("msr daifset, #3" : : : "memory");
+}
+
#endif /* SELFTEST_KVM_PROCESSOR_H */
--
2.33.0.153.gba50c8fa24-goog

2021-09-01 23:40:18

by Oliver Upton

Subject: Re: [PATCH v3 06/12] KVM: arm64: selftests: Add support to disable and enable local IRQs

On Wed, Sep 01, 2021 at 09:14:06PM +0000, Raghavendra Rao Ananta wrote:
> Add functions local_irq_enable() and local_irq_disable() to
> enable and disable the IRQs from the guest, respectively.
>
> Signed-off-by: Raghavendra Rao Ananta <[email protected]>

Reviewed-by: Oliver Upton <[email protected]>

> ---
> .../testing/selftests/kvm/include/aarch64/processor.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/tools/testing/selftests/kvm/include/aarch64/processor.h b/tools/testing/selftests/kvm/include/aarch64/processor.h
> index 78df059dc974..c35bb7b8e870 100644
> --- a/tools/testing/selftests/kvm/include/aarch64/processor.h
> +++ b/tools/testing/selftests/kvm/include/aarch64/processor.h
> @@ -241,4 +241,14 @@ static __always_inline u32 __raw_readl(const volatile void *addr)
> #define writel(v,c) ({ __iowmb(); writel_relaxed((v),(c));})
> #define readl(c) ({ u32 __v = readl_relaxed(c); __iormb(__v); __v; })
>
> +static inline void local_irq_enable(void)
> +{
> + asm volatile("msr daifclr, #3" : : : "memory");
> +}
> +
> +static inline void local_irq_disable(void)
> +{
> + asm volatile("msr daifset, #3" : : : "memory");
> +}
> +
> #endif /* SELFTEST_KVM_PROCESSOR_H */
> --
> 2.33.0.153.gba50c8fa24-goog
>

2021-09-02 20:04:44

by Andrew Jones

Subject: Re: [PATCH v3 06/12] KVM: arm64: selftests: Add support to disable and enable local IRQs

On Wed, Sep 01, 2021 at 09:14:06PM +0000, Raghavendra Rao Ananta wrote:
> Add functions local_irq_enable() and local_irq_disable() to
> enable and disable the IRQs from the guest, respectively.
>
> Signed-off-by: Raghavendra Rao Ananta <[email protected]>
> ---
> .../testing/selftests/kvm/include/aarch64/processor.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>

Reviewed-by: Andrew Jones <[email protected]>