2021-09-02 21:31:26

by Colin King

Subject: [PATCH][next] vfio/pci: add missing identifier name in argument of function prototype

From: Colin Ian King <[email protected]>

The function prototype is missing an identifier name. Add one.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/vfio/pci/vfio_pci_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vfio/pci/vfio_pci_core.c b/drivers/vfio/pci/vfio_pci_core.c
index 68198e0f2a63..a03b5a99c2da 100644
--- a/drivers/vfio/pci/vfio_pci_core.c
+++ b/drivers/vfio/pci/vfio_pci_core.c
@@ -565,7 +565,7 @@ static bool vfio_pci_dev_below_slot(struct pci_dev *pdev, struct pci_slot *slot)
}

struct vfio_pci_walk_info {
- int (*fn)(struct pci_dev *, void *data);
+ int (*fn)(struct pci_dev *pdev, void *data);
void *data;
struct pci_dev *pdev;
bool slot;
--
2.32.0

2021-09-03 13:10:26

by Jason Gunthorpe

Subject: Re: [PATCH][next] vfio/pci: add missing identifier name in argument of function prototype

On Thu, Sep 02, 2021 at 10:26:31PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The function prototype is missing an identifier name. Add one.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/vfio/pci/vfio_pci_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

It seems fine, but is there a reason to just pick this one case and
not clean the whole subsystem?

Eg i see a couple more cases in the headers

Reviewed-by: Jason Gunthorpe <[email protected]>

Jason