2021-09-03 00:06:30

by Colin King

Subject: [PATCH][next] drm/amdgpu: clean up inconsistent indenting

From: Colin Ian King <[email protected]>

There are a couple of statements that are indented one character
too deeply, clean these up.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
index d6aa032890ee..a573424a6e0b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
@@ -60,10 +60,9 @@ static vm_fault_t amdgpu_gem_fault(struct vm_fault *vmf)
goto unlock;
}

- ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
- TTM_BO_VM_NUM_PREFAULT, 1);
-
- drm_dev_exit(idx);
+ ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
+ TTM_BO_VM_NUM_PREFAULT, 1);
+ drm_dev_exit(idx);
} else {
ret = ttm_bo_vm_dummy_page(vmf, vmf->vma->vm_page_prot);
}
--
2.32.0

2021-09-03 06:32:41

by Christian König

Subject: Re: [PATCH][next] drm/amdgpu: clean up inconsistent indenting

Am 02.09.21 um 23:45 schrieb Colin King:
> From: Colin Ian King <[email protected]>
>
> There are a couple of statements that are indented one character
> too deeply, clean these up.
>
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Christian König <[email protected]>

> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> index d6aa032890ee..a573424a6e0b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> @@ -60,10 +60,9 @@ static vm_fault_t amdgpu_gem_fault(struct vm_fault *vmf)
> goto unlock;
> }
>
> - ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
> - TTM_BO_VM_NUM_PREFAULT, 1);
> -
> - drm_dev_exit(idx);
> + ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
> + TTM_BO_VM_NUM_PREFAULT, 1);
> + drm_dev_exit(idx);
> } else {
> ret = ttm_bo_vm_dummy_page(vmf, vmf->vma->vm_page_prot);
> }

2021-09-07 17:45:05

by Alex Deucher

Subject: Re: [PATCH][next] drm/amdgpu: clean up inconsistent indenting

Applied. Thanks!

Alex

On Fri, Sep 3, 2021 at 2:31 AM Christian König <[email protected]> wrote:
>
> Am 02.09.21 um 23:45 schrieb Colin King:
> > From: Colin Ian King <[email protected]>
> >
> > There are a couple of statements that are indented one character
> > too deeply, clean these up.
> >
> > Signed-off-by: Colin Ian King <[email protected]>
>
> Reviewed-by: Christian König <[email protected]>
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> > index d6aa032890ee..a573424a6e0b 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> > @@ -60,10 +60,9 @@ static vm_fault_t amdgpu_gem_fault(struct vm_fault *vmf)
> > goto unlock;
> > }
> >
> > - ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
> > - TTM_BO_VM_NUM_PREFAULT, 1);
> > -
> > - drm_dev_exit(idx);
> > + ret = ttm_bo_vm_fault_reserved(vmf, vmf->vma->vm_page_prot,
> > + TTM_BO_VM_NUM_PREFAULT, 1);
> > + drm_dev_exit(idx);
> > } else {
> > ret = ttm_bo_vm_dummy_page(vmf, vmf->vma->vm_page_prot);
> > }
>