2021-09-03 13:27:47

by Colin King

Subject: [PATCH][next] fs/ntfs3: Remove redundant initialization of variable err

From: Colin Ian King <[email protected]>

The variable err is being initialized with a value that is never read, it
is being updated later on. The assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
fs/ntfs3/index.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
index 0daca9adc54c..b1175542d854 100644
--- a/fs/ntfs3/index.c
+++ b/fs/ntfs3/index.c
@@ -1401,7 +1401,7 @@ int indx_find_raw(struct ntfs_index *indx, struct ntfs_inode *ni,
static int indx_create_allocate(struct ntfs_index *indx, struct ntfs_inode *ni,
CLST *vbn)
{
- int err = -ENOMEM;
+ int err;
struct ntfs_sb_info *sbi = ni->mi.sbi;
struct ATTRIB *bitmap;
struct ATTRIB *alloc;
--
2.32.0

2021-09-03 16:15:24

by Kari Argillander

Subject: Re: [PATCH][next] fs/ntfs3: Remove redundant initialization of variable err

On Fri, Sep 03, 2021 at 02:24:58PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable err is being initialized with a value that is never read, it
> is being updated later on. The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: Kari Argillander <[email protected]>

Please note Konstantin that you should not yet, put this to master. You
can collect these already, but if ntfs3 get merged to 5.15 we will start
start master again later. You could but these in example devel if you
want.

Then we also need branch just for bug fixes. Example this will have to
go to 5.16 because it is not bug fix. Our master is our for-next branch
so this will go there when time comes.

> ---
> fs/ntfs3/index.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
> index 0daca9adc54c..b1175542d854 100644
> --- a/fs/ntfs3/index.c
> +++ b/fs/ntfs3/index.c
> @@ -1401,7 +1401,7 @@ int indx_find_raw(struct ntfs_index *indx, struct ntfs_inode *ni,
> static int indx_create_allocate(struct ntfs_index *indx, struct ntfs_inode *ni,
> CLST *vbn)
> {
> - int err = -ENOMEM;
> + int err;
> struct ntfs_sb_info *sbi = ni->mi.sbi;
> struct ATTRIB *bitmap;
> struct ATTRIB *alloc;
> --
> 2.32.0
>

2021-09-13 16:52:40

by Konstantin Komarov

Subject: Re: [PATCH][next] fs/ntfs3: Remove redundant initialization of variable err

On 03.09.2021 16:24, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The variable err is being initialized with a value that is never read, it
> is being updated later on. The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> fs/ntfs3/index.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
> index 0daca9adc54c..b1175542d854 100644
> --- a/fs/ntfs3/index.c
> +++ b/fs/ntfs3/index.c
> @@ -1401,7 +1401,7 @@ int indx_find_raw(struct ntfs_index *indx, struct ntfs_inode *ni,
> static int indx_create_allocate(struct ntfs_index *indx, struct ntfs_inode *ni,
> CLST *vbn)
> {
> - int err = -ENOMEM;
> + int err;
> struct ntfs_sb_info *sbi = ni->mi.sbi;
> struct ATTRIB *bitmap;
> struct ATTRIB *alloc;
>

Hi Colin, thanks for the patch - applied it.

Best regards.