2021-09-04 15:30:13

by Miles Chen

Subject: [PATCH v2] clk: rockchip: use module_platform_driver_probe

Replace builtin_platform_driver_probe with module_platform_driver_probe
because that rk3399 and rk3568 can be built as kernel modules.

Fixes: 70d839e2761d ("clk: rockchip: rk3399: Support module build")
Fixes: cf911d89c4c5 ("clk: rockchip: add clock controller for rk3568")
Cc: Heiko Stuebner <[email protected]>
Cc: Stephen Boyd <[email protected]>
Tested-by: Heiko Stuebner <[email protected]>
Reviewed-by: Heiko Stuebner <[email protected]>
Signed-off-by: Miles Chen <[email protected]>

---

Change since v1:
Add Fixes tags

---
drivers/clk/rockchip/clk-rk3399.c | 2 +-
drivers/clk/rockchip/clk-rk3568.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/rockchip/clk-rk3399.c b/drivers/clk/rockchip/clk-rk3399.c
index 62a4f2543960..a5169156f1d2 100644
--- a/drivers/clk/rockchip/clk-rk3399.c
+++ b/drivers/clk/rockchip/clk-rk3399.c
@@ -1653,7 +1653,7 @@ static struct platform_driver clk_rk3399_driver = {
.suppress_bind_attrs = true,
},
};
-builtin_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);
+module_platform_driver_probe(clk_rk3399_driver, clk_rk3399_probe);

MODULE_DESCRIPTION("Rockchip RK3399 Clock Driver");
MODULE_LICENSE("GPL");
diff --git a/drivers/clk/rockchip/clk-rk3568.c b/drivers/clk/rockchip/clk-rk3568.c
index 75ca855e720d..939e7079c334 100644
--- a/drivers/clk/rockchip/clk-rk3568.c
+++ b/drivers/clk/rockchip/clk-rk3568.c
@@ -1719,7 +1719,7 @@ static struct platform_driver clk_rk3568_driver = {
.suppress_bind_attrs = true,
},
};
-builtin_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);
+module_platform_driver_probe(clk_rk3568_driver, clk_rk3568_probe);

MODULE_DESCRIPTION("Rockchip RK3568 Clock Driver");
MODULE_LICENSE("GPL");
--
2.18.0

2021-09-05 20:54:58

by Stephen Boyd

Subject: Re: [PATCH v2] clk: rockchip: use module_platform_driver_probe

Quoting Miles Chen (2021-09-04 08:28:56)
> Replace builtin_platform_driver_probe with module_platform_driver_probe
> because that rk3399 and rk3568 can be built as kernel modules.
>
> Fixes: 70d839e2761d ("clk: rockchip: rk3399: Support module build")
> Fixes: cf911d89c4c5 ("clk: rockchip: add clock controller for rk3568")
> Cc: Heiko Stuebner <[email protected]>
> Cc: Stephen Boyd <[email protected]>
> Tested-by: Heiko Stuebner <[email protected]>
> Reviewed-by: Heiko Stuebner <[email protected]>
> Signed-off-by: Miles Chen <[email protected]>
>
> ---

Reviewed-by: Stephen Boyd <[email protected]>

2021-09-20 16:46:34

by Heiko Stübner

Subject: Re: [PATCH v2] clk: rockchip: use module_platform_driver_probe

On Sat, 4 Sep 2021 23:28:56 +0800, Miles Chen wrote:
> Replace builtin_platform_driver_probe with module_platform_driver_probe
> because that rk3399 and rk3568 can be built as kernel modules.

Applied, thanks!

[1/1] clk: rockchip: use module_platform_driver_probe
commit: bb232c4c2a4bcab2ceff494a6d3b0869601f06d1

Best regards,
--
Heiko Stuebner <[email protected]>