2021-09-04 15:31:41

by Miles Chen

Subject: [PATCH v2] clk: imx: use module_platform_driver

Replace builtin_platform_driver_probe with module_platform_driver_probe
because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).

Fixes: c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
Fixes: 1e3121bfe51a ("clk: imx: add imx8qxp lpcg driver")
Cc: Stephen Boyd <[email protected]>
Signed-off-by: Miles Chen <[email protected]>

---

Change since v1:
Add Fixes tags

---
drivers/clk/imx/clk-imx8qxp-lpcg.c | 2 +-
drivers/clk/imx/clk-imx8qxp.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/imx/clk-imx8qxp-lpcg.c b/drivers/clk/imx/clk-imx8qxp-lpcg.c
index d3e905cf867d..b23758083ce5 100644
--- a/drivers/clk/imx/clk-imx8qxp-lpcg.c
+++ b/drivers/clk/imx/clk-imx8qxp-lpcg.c
@@ -370,7 +370,7 @@ static struct platform_driver imx8qxp_lpcg_clk_driver = {
.probe = imx8qxp_lpcg_clk_probe,
};

-builtin_platform_driver(imx8qxp_lpcg_clk_driver);
+module_platform_driver(imx8qxp_lpcg_clk_driver);

MODULE_AUTHOR("Aisheng Dong <[email protected]>");
MODULE_DESCRIPTION("NXP i.MX8QXP LPCG clock driver");
diff --git a/drivers/clk/imx/clk-imx8qxp.c b/drivers/clk/imx/clk-imx8qxp.c
index c53a688d8ccc..40a2efb1329b 100644
--- a/drivers/clk/imx/clk-imx8qxp.c
+++ b/drivers/clk/imx/clk-imx8qxp.c
@@ -308,7 +308,7 @@ static struct platform_driver imx8qxp_clk_driver = {
},
.probe = imx8qxp_clk_probe,
};
-builtin_platform_driver(imx8qxp_clk_driver);
+module_platform_driver(imx8qxp_clk_driver);

MODULE_AUTHOR("Aisheng Dong <[email protected]>");
MODULE_DESCRIPTION("NXP i.MX8QXP clock driver");
--
2.18.0

2021-09-04 16:49:05

by Fabio Estevam

Subject: Re: [PATCH v2] clk: imx: use module_platform_driver

Hi Miles,

On Sat, Sep 4, 2021 at 12:29 PM Miles Chen <[email protected]> wrote:
>
> Replace builtin_platform_driver_probe with module_platform_driver_probe
> because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).
>
> Fixes: c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
> Fixes: 1e3121bfe51a ("clk: imx: add imx8qxp lpcg driver")

The correct Fixes tag would be:

Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock
driver as module")

Thanks

2021-09-04 23:58:17

by Miles Chen

Subject: Re: [PATCH v2] clk: imx: use module_platform_driver

On Sat, 2021-09-04 at 13:43 -0300, Fabio Estevam wrote:
> Hi Miles,
>
> On Sat, Sep 4, 2021 at 12:29 PM Miles Chen <[email protected]>
> wrote:
> >
> > Replace builtin_platform_driver_probe with
> > module_platform_driver_probe
> > because CONFIG_CLK_IMX8QXP can be set to =m (kernel module).
> >
> > Fixes: c2cccb6d0b33 ("clk: imx: add imx8qxp clk driver")
> > Fixes: 1e3121bfe51a ("clk: imx: add imx8qxp lpcg driver")
>
> The correct Fixes tag would be:
>
> Fixes: e0d0d4d86c766 ("clk: imx8qxp: Support building i.MX8QXP clock
> driver as module")
>

Thanks, I will fix the tag in next patch.

Miles
> Thanks