2021-09-07 08:04:55

by Cai,Huoqing

[permalink] [raw]

Subject: [PATCH] mailbox: tegra-hsp: Make use of the helper function devm_platform_ioremap_resource()

---

Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/mailbox/tegra-hsp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mailbox/tegra-hsp.c b/drivers/mailbox/tegra-hsp.c
index acd0675da681..bfd70934a25e 100644
--- a/drivers/mailbox/tegra-hsp.c
+++ b/drivers/mailbox/tegra-hsp.c
@@ -640,7 +640,6 @@ static int tegra_hsp_request_shared_irq(struct tegra_hsp *hsp)
static int tegra_hsp_probe(struct platform_device *pdev)
{
struct tegra_hsp *hsp;
- struct resource *res;
unsigned int i;
u32 value;
int err;
@@ -654,8 +653,7 @@ static int tegra_hsp_probe(struct platform_device *pdev)
INIT_LIST_HEAD(&hsp->doorbells);
spin_lock_init(&hsp->lock);

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- hsp->regs = devm_ioremap_resource(&pdev->dev, res);
+ hsp->regs = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(hsp->regs))
return PTR_ERR(hsp->regs);

--
2.25.1

2021-10-07 20:12:25

by Thierry Reding

[permalink] [raw]

Subject: Re: [PATCH] mailbox: tegra-hsp: Make use of the helper function devm_platform_ioremap_resource()

---

On Tue, Sep 07, 2021 at 03:42:07PM +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <[email protected]>
> ---
> drivers/mailbox/tegra-hsp.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Acked-by: Thierry Reding <[email protected]>

---

Attachments:

(No filename) (406.00 B)
signature.asc (849.00 B)
Download all attachments