2021-09-07 15:37:19

by Kari Argillander

Subject: [PATCH v4 1/9] fs/ntfs3: Remove unnecesarry mount option noatime

Remove unnecesarry mount option noatime because this will be handled
by VFS. Our option parser will never get opt like this.

Acked-by: Christian Brauner <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Signed-off-by: Kari Argillander <[email protected]>
---
Documentation/filesystems/ntfs3.rst | 4 ----
fs/ntfs3/super.c | 7 -------
2 files changed, 11 deletions(-)

diff --git a/Documentation/filesystems/ntfs3.rst b/Documentation/filesystems/ntfs3.rst
index ffe9ea0c1499..af7158de6fde 100644
--- a/Documentation/filesystems/ntfs3.rst
+++ b/Documentation/filesystems/ntfs3.rst
@@ -85,10 +85,6 @@ acl Support POSIX ACLs (Access Control Lists). Effective if
supported by Kernel. Not to be confused with NTFS ACLs.
The option specified as acl enables support for POSIX ACLs.

-noatime All files and directories will not update their last access
- time attribute if a partition is mounted with this parameter.
- This option can speed up file system operation.
-
===============================================================================

ToDo list
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index 55bbc9200a10..a18b99a3e3b5 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -223,7 +223,6 @@ enum Opt {
Opt_nohidden,
Opt_showmeta,
Opt_acl,
- Opt_noatime,
Opt_nls,
Opt_prealloc,
Opt_no_acs_rules,
@@ -242,7 +241,6 @@ static const match_table_t ntfs_tokens = {
{ Opt_sparse, "sparse" },
{ Opt_nohidden, "nohidden" },
{ Opt_acl, "acl" },
- { Opt_noatime, "noatime" },
{ Opt_showmeta, "showmeta" },
{ Opt_nls, "nls=%s" },
{ Opt_prealloc, "prealloc" },
@@ -333,9 +331,6 @@ static noinline int ntfs_parse_options(struct super_block *sb, char *options,
ntfs_err(sb, "support for ACL not compiled in!");
return -EINVAL;
#endif
- case Opt_noatime:
- sb->s_flags |= SB_NOATIME;
- break;
case Opt_showmeta:
opts->showmeta = 1;
break;
@@ -587,8 +582,6 @@ static int ntfs_show_options(struct seq_file *m, struct dentry *root)
seq_puts(m, ",prealloc");
if (sb->s_flags & SB_POSIXACL)
seq_puts(m, ",acl");
- if (sb->s_flags & SB_NOATIME)
- seq_puts(m, ",noatime");

return 0;
}
--
2.25.1

2021-09-08 19:12:35

by Pali Rohár

Subject: Re: [PATCH v4 1/9] fs/ntfs3: Remove unnecesarry mount option noatime

On Tuesday 07 September 2021 18:35:49 Kari Argillander wrote:
> Remove unnecesarry mount option noatime because this will be handled
> by VFS. Our option parser will never get opt like this.
>
> Acked-by: Christian Brauner <[email protected]>
> Reviewed-by: Christoph Hellwig <[email protected]>
> Signed-off-by: Kari Argillander <[email protected]>

Reviewed-by: Pali Rohár <[email protected]>

> ---
> Documentation/filesystems/ntfs3.rst | 4 ----
> fs/ntfs3/super.c | 7 -------
> 2 files changed, 11 deletions(-)
>
> diff --git a/Documentation/filesystems/ntfs3.rst b/Documentation/filesystems/ntfs3.rst
> index ffe9ea0c1499..af7158de6fde 100644
> --- a/Documentation/filesystems/ntfs3.rst
> +++ b/Documentation/filesystems/ntfs3.rst
> @@ -85,10 +85,6 @@ acl Support POSIX ACLs (Access Control Lists). Effective if
> supported by Kernel. Not to be confused with NTFS ACLs.
> The option specified as acl enables support for POSIX ACLs.
>
> -noatime All files and directories will not update their last access
> - time attribute if a partition is mounted with this parameter.
> - This option can speed up file system operation.
> -
> ===============================================================================
>
> ToDo list
> diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
> index 55bbc9200a10..a18b99a3e3b5 100644
> --- a/fs/ntfs3/super.c
> +++ b/fs/ntfs3/super.c
> @@ -223,7 +223,6 @@ enum Opt {
> Opt_nohidden,
> Opt_showmeta,
> Opt_acl,
> - Opt_noatime,
> Opt_nls,
> Opt_prealloc,
> Opt_no_acs_rules,
> @@ -242,7 +241,6 @@ static const match_table_t ntfs_tokens = {
> { Opt_sparse, "sparse" },
> { Opt_nohidden, "nohidden" },
> { Opt_acl, "acl" },
> - { Opt_noatime, "noatime" },
> { Opt_showmeta, "showmeta" },
> { Opt_nls, "nls=%s" },
> { Opt_prealloc, "prealloc" },
> @@ -333,9 +331,6 @@ static noinline int ntfs_parse_options(struct super_block *sb, char *options,
> ntfs_err(sb, "support for ACL not compiled in!");
> return -EINVAL;
> #endif
> - case Opt_noatime:
> - sb->s_flags |= SB_NOATIME;
> - break;
> case Opt_showmeta:
> opts->showmeta = 1;
> break;
> @@ -587,8 +582,6 @@ static int ntfs_show_options(struct seq_file *m, struct dentry *root)
> seq_puts(m, ",prealloc");
> if (sb->s_flags & SB_POSIXACL)
> seq_puts(m, ",acl");
> - if (sb->s_flags & SB_NOATIME)
> - seq_puts(m, ",noatime");
>
> return 0;
> }
> --
> 2.25.1
>