2021-09-08 10:58:30

by Cai,Huoqing

Subject: [PATCH] irqchip/irq-mvebu-pic: Make use of the helper function devm_platform_ioremap_resource()

Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/irqchip/irq-mvebu-pic.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-mvebu-pic.c b/drivers/irqchip/irq-mvebu-pic.c
index dc1cee4b0fe1..870f9866b8da 100644
--- a/drivers/irqchip/irq-mvebu-pic.c
+++ b/drivers/irqchip/irq-mvebu-pic.c
@@ -121,14 +121,12 @@ static int mvebu_pic_probe(struct platform_device *pdev)
struct device_node *node = pdev->dev.of_node;
struct mvebu_pic *pic;
struct irq_chip *irq_chip;
- struct resource *res;

pic = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_pic), GFP_KERNEL);
if (!pic)
return -ENOMEM;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- pic->base = devm_ioremap_resource(&pdev->dev, res);
+ pic->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(pic->base))
return PTR_ERR(pic->base);

--
2.25.1

2021-09-08 12:30:00

by Andrew Lunn

Subject: Re: [PATCH] irqchip/irq-mvebu-pic: Make use of the helper function devm_platform_ioremap_resource()

On Wed, Sep 08, 2021 at 06:57:00PM +0800, Cai Huoqing wrote:
> Use the devm_platform_ioremap_resource() helper instead of
> calling platform_get_resource() and devm_ioremap_resource()
> separately
>
> Signed-off-by: Cai Huoqing <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2021-10-20 18:49:30

by tip-bot2 for Alexey Makhalov

Subject: [irqchip: irq/irqchip-next] irqchip/irq-mvebu-pic: Make use of the helper function devm_platform_ioremap_resource()

The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID: bacdbd710de553c9c998235231139f0921a5750c
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/bacdbd710de553c9c998235231139f0921a5750c
Author: Cai Huoqing <[email protected]>
AuthorDate: Wed, 08 Sep 2021 18:57:00 +08:00
Committer: Marc Zyngier <[email protected]>
CommitterDate: Tue, 19 Oct 2021 11:22:59 +01:00

irqchip/irq-mvebu-pic: Make use of the helper function devm_platform_ioremap_resource()

Use the devm_platform_ioremap_resource() helper instead of
calling platform_get_resource() and devm_ioremap_resource()
separately

Signed-off-by: Cai Huoqing <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]>
Signed-off-by: Marc Zyngier <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
drivers/irqchip/irq-mvebu-pic.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/irqchip/irq-mvebu-pic.c b/drivers/irqchip/irq-mvebu-pic.c
index dc1cee4..870f986 100644
--- a/drivers/irqchip/irq-mvebu-pic.c
+++ b/drivers/irqchip/irq-mvebu-pic.c
@@ -121,14 +121,12 @@ static int mvebu_pic_probe(struct platform_device *pdev)
struct device_node *node = pdev->dev.of_node;
struct mvebu_pic *pic;
struct irq_chip *irq_chip;
- struct resource *res;

pic = devm_kzalloc(&pdev->dev, sizeof(struct mvebu_pic), GFP_KERNEL);
if (!pic)
return -ENOMEM;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- pic->base = devm_ioremap_resource(&pdev->dev, res);
+ pic->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(pic->base))
return PTR_ERR(pic->base);