2021-09-08 14:18:37

by Bert Vermeulen

Subject: [PATCH v3 2/5] dt-bindings: arm: airoha: Add binding for EN7523 SoC and EVB

From: John Crispin <[email protected]>

Add devicetree binding for Airoha EN7523 SoC and evaluation board.

Signed-off-by: John Crispin <[email protected]>
Signed-off-by: Bert Vermeulen <[email protected]>
---
.../devicetree/bindings/arm/airoha.yaml | 27 +++++++++++++++++++
1 file changed, 27 insertions(+)
create mode 100644 Documentation/devicetree/bindings/arm/airoha.yaml

diff --git a/Documentation/devicetree/bindings/arm/airoha.yaml b/Documentation/devicetree/bindings/arm/airoha.yaml
new file mode 100644
index 000000000000..f2661ba81109
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/airoha.yaml
@@ -0,0 +1,27 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/airoha.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Airoha SoC based Platforms Device Tree Bindings
+
+maintainers:
+ - Felix Fietkau <[email protected]>
+ - John Crispin <[email protected]>
+description: |
+ Boards with an Airoha SoC shall have the following properties.
+
+properties:
+ $nodename:
+ const: '/'
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - airoha,en7523-evb
+ - const: airoha,en7523
+
+additionalProperties: true
+
+...
--
2.25.1

2021-09-21 03:49:17

by Rob Herring

Subject: Re: [PATCH v3 2/5] dt-bindings: arm: airoha: Add binding for EN7523 SoC and EVB

On Wed, Sep 08, 2021 at 04:16:03PM +0200, Bert Vermeulen wrote:
> From: John Crispin <[email protected]>
>
> Add devicetree binding for Airoha EN7523 SoC and evaluation board.
>
> Signed-off-by: John Crispin <[email protected]>
> Signed-off-by: Bert Vermeulen <[email protected]>
> ---
> .../devicetree/bindings/arm/airoha.yaml | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/airoha.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/airoha.yaml b/Documentation/devicetree/bindings/arm/airoha.yaml
> new file mode 100644
> index 000000000000..f2661ba81109
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/airoha.yaml
> @@ -0,0 +1,27 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/airoha.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Airoha SoC based Platforms Device Tree Bindings
> +
> +maintainers:
> + - Felix Fietkau <[email protected]>
> + - John Crispin <[email protected]>

Blank line.

> +description: |

Don't need '|' here.

> + Boards with an Airoha SoC shall have the following properties.
> +
> +properties:
> + $nodename:
> + const: '/'
> + compatible:
> + oneOf:

Don't need oneOf with only 1 entry.

> + - items:
> + - enum:
> + - airoha,en7523-evb
> + - const: airoha,en7523
> +
> +additionalProperties: true
> +
> +...
> --
> 2.25.1
>
>