2021-09-09 22:48:44

by David Virag

[permalink] [raw]
Subject: [PATCH] soc: samsung: exynos-pmu: Fix compilation when nothing selects CONFIG_MFD_CORE

Commit 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")
adds a "devm_mfd_add_devices" call in the exynos-pmu driver which depends
on CONFIG_MFD_CORE. If no driver selects that config, the build will fail
if CONFIG_EXYNOS_PMU is enabled with the following error:
drivers/soc/samsung/exynos-pmu.c:137: undefined reference to `devm_mfd_add_devices'

Fix this by making CONFIG_EXYNOS_PMU select CONFIG_MFD_CORE.
Fixes: 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")

Signed-off-by: David Virag <[email protected]>
---
drivers/soc/samsung/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig
index 5745d7e5908e..1f643c0f5c93 100644
--- a/drivers/soc/samsung/Kconfig
+++ b/drivers/soc/samsung/Kconfig
@@ -25,6 +25,7 @@ config EXYNOS_PMU
bool "Exynos PMU controller driver" if COMPILE_TEST
depends on ARCH_EXYNOS || ((ARM || ARM64) && COMPILE_TEST)
select EXYNOS_PMU_ARM_DRIVERS if ARM && ARCH_EXYNOS
+ select MFD_CORE

# There is no need to enable these drivers for ARMv8
config EXYNOS_PMU_ARM_DRIVERS
--
2.33.0


2021-09-15 07:55:24

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] soc: samsung: exynos-pmu: Fix compilation when nothing selects CONFIG_MFD_CORE

On Fri, 10 Sep 2021 00:28:12 +0200, David Virag wrote:
> Commit 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")
> adds a "devm_mfd_add_devices" call in the exynos-pmu driver which depends
> on CONFIG_MFD_CORE. If no driver selects that config, the build will fail
> if CONFIG_EXYNOS_PMU is enabled with the following error:
> drivers/soc/samsung/exynos-pmu.c:137: undefined reference to `devm_mfd_add_devices'
>
> Fix this by making CONFIG_EXYNOS_PMU select CONFIG_MFD_CORE.
> Fixes: 93618e344a5e ("soc: samsung: exynos-pmu: instantiate clkout driver as MFD")
>
> [...]

Applied, thanks!

[1/1] soc: samsung: exynos-pmu: Fix compilation when nothing selects CONFIG_MFD_CORE
commit: e37ef6dcdb1f4738b01cec7fb7be46af07816af9

Best regards,
--
Krzysztof Kozlowski <[email protected]>