2021-09-10 02:26:51

by Xu Wang

Subject: [PATCH] xen-blkback: Remove needless request_queue NULL pointer check

The request_queue pointer returned from bdev_get_queue() shall
never be NULL, so the null check is unnecessary, just remove it.

Signed-off-by: Xu Wang <[email protected]>
---
drivers/block/xen-blkback/xenbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index 33eba3df4dd9..f05132b9ddbf 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -516,7 +516,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
vbd->type |= VDISK_REMOVABLE;

q = bdev_get_queue(bdev);
- if (q && test_bit(QUEUE_FLAG_WC, &q->queue_flags))
+ if test_bit(QUEUE_FLAG_WC, &q->queue_flags)
vbd->flush_support = true;

if (q && blk_queue_secure_erase(q))
--
2.17.1

2021-09-10 02:38:54

by Damien Le Moal

Subject: Re: [PATCH] xen-blkback: Remove needless request_queue NULL pointer check

On 2021/09/10 11:32, Xu Wang wrote:
> The request_queue pointer returned from bdev_get_queue() shall
> never be NULL, so the null check is unnecessary, just remove it.
>
> Signed-off-by: Xu Wang <[email protected]>
> ---
> drivers/block/xen-blkback/xenbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
> index 33eba3df4dd9..f05132b9ddbf 100644
> --- a/drivers/block/xen-blkback/xenbus.c
> +++ b/drivers/block/xen-blkback/xenbus.c
> @@ -516,7 +516,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
> vbd->type |= VDISK_REMOVABLE;
>
> q = bdev_get_queue(bdev);
> - if (q && test_bit(QUEUE_FLAG_WC, &q->queue_flags))
> + if test_bit(QUEUE_FLAG_WC, &q->queue_flags)

Missing parenthesis. Did you even compile this ?


> vbd->flush_support = true;
>
> if (q && blk_queue_secure_erase(q))

And why not change this one too ?

>


--
Damien Le Moal
Western Digital Research