2021-09-12 16:03:19

by Leo Liang

[permalink] [raw]
Subject: [PATCH 1/2] doc: Fix typo in Documentation/riscv/vm-layout

From: Leo Yu-Chi Liang <[email protected]>

Fix a typo of the End Addr field for `direct mapping` section.

The value 0xffffffff7fffffff - 0xffffffe000000000 is 126 GB
and is not equal to value in the size field.

Update the value to make sense of the memory layout table.

Signed-off-by: Leo Yu-Chi Liang <[email protected]>
---
Documentation/riscv/vm-layout.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/riscv/vm-layout.rst b/Documentation/riscv/vm-layout.rst
index b7f98930d38d..2525cf0d6794 100644
--- a/Documentation/riscv/vm-layout.rst
+++ b/Documentation/riscv/vm-layout.rst
@@ -52,7 +52,7 @@ RISC-V Linux Kernel SV39
ffffffceff000000 | -196 GB | ffffffceffffffff | 16 MB | PCI io
ffffffcf00000000 | -196 GB | ffffffcfffffffff | 4 GB | vmemmap
ffffffd000000000 | -192 GB | ffffffdfffffffff | 64 GB | vmalloc/ioremap space
- ffffffe000000000 | -128 GB | ffffffff7fffffff | 124 GB | direct mapping of all physical memory
+ ffffffe000000000 | -128 GB | fffffffeffffffff | 124 GB | direct mapping of all physical memory
__________________|____________|__________________|_________|____________________________________________________________
|
|
--
2.25.1


2021-09-14 00:41:09

by Alexandre Ghiti

[permalink] [raw]
Subject: Re: [PATCH 1/2] doc: Fix typo in Documentation/riscv/vm-layout

(+cc linux-riscv)

On 9/12/21 5:51 PM, Leo Yu-Chi Liang wrote:
> From: Leo Yu-Chi Liang <[email protected]>
>
> Fix a typo of the End Addr field for `direct mapping` section.
>
> The value 0xffffffff7fffffff - 0xffffffe000000000 is 126 GB
> and is not equal to value in the size field.
>
> Update the value to make sense of the memory layout table.
>
> Signed-off-by: Leo Yu-Chi Liang <[email protected]>
> ---
> Documentation/riscv/vm-layout.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/riscv/vm-layout.rst b/Documentation/riscv/vm-layout.rst
> index b7f98930d38d..2525cf0d6794 100644
> --- a/Documentation/riscv/vm-layout.rst
> +++ b/Documentation/riscv/vm-layout.rst
> @@ -52,7 +52,7 @@ RISC-V Linux Kernel SV39
> ffffffceff000000 | -196 GB | ffffffceffffffff | 16 MB | PCI io
> ffffffcf00000000 | -196 GB | ffffffcfffffffff | 4 GB | vmemmap
> ffffffd000000000 | -192 GB | ffffffdfffffffff | 64 GB | vmalloc/ioremap space
> - ffffffe000000000 | -128 GB | ffffffff7fffffff | 124 GB | direct mapping of all physical memory
> + ffffffe000000000 | -128 GB | fffffffeffffffff | 124 GB | direct mapping of all physical memory
> __________________|____________|__________________|_________|____________________________________________________________
> |
> |

You're right, thanks for catching this, you can add:

Reviewed-by: Alexandre Ghiti <[email protected]>

Thanks again,

Alex