2021-09-08 09:39:19

by Shengjiu Wang

Subject: [PATCH v4 2/4] remoteproc: imx_rproc: Add IMX_RPROC_SCU_API method

On i.MX8QM and i.MX8QXP, most devices are controlled
by System Control Unit, so add IMX_RPROC_SCU_API
method for these platform.

Signed-off-by: Shengjiu Wang <[email protected]>
---
drivers/remoteproc/imx_rproc.h | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h
index 23d8e808d27f..1c7e2127c758 100644
--- a/drivers/remoteproc/imx_rproc.h
+++ b/drivers/remoteproc/imx_rproc.h
@@ -22,6 +22,8 @@ enum imx_rproc_method {
IMX_RPROC_MMIO,
/* Through ARM SMCCC */
IMX_RPROC_SMC,
+ /* Through System Control Unit API */
+ IMX_RPROC_SCU_API,
};

struct imx_rproc_dcfg {
--
2.17.1

2021-09-14 17:49:39

by Mathieu Poirier

Subject: Re: [PATCH v4 2/4] remoteproc: imx_rproc: Add IMX_RPROC_SCU_API method

On Wed, Sep 08, 2021 at 05:10:53PM +0800, Shengjiu Wang wrote:
> On i.MX8QM and i.MX8QXP, most devices are controlled
> by System Control Unit, so add IMX_RPROC_SCU_API
> method for these platform.
>
> Signed-off-by: Shengjiu Wang <[email protected]>
> ---
> drivers/remoteproc/imx_rproc.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/remoteproc/imx_rproc.h b/drivers/remoteproc/imx_rproc.h
> index 23d8e808d27f..1c7e2127c758 100644
> --- a/drivers/remoteproc/imx_rproc.h
> +++ b/drivers/remoteproc/imx_rproc.h
> @@ -22,6 +22,8 @@ enum imx_rproc_method {
> IMX_RPROC_MMIO,
> /* Through ARM SMCCC */
> IMX_RPROC_SMC,
> + /* Through System Control Unit API */
> + IMX_RPROC_SCU_API,

So much better now...

Reviewed-by: Mathieu Poirier <[email protected]>

> };
>
> struct imx_rproc_dcfg {
> --
> 2.17.1
>