Set regmap raw read/write from spi max_transfer_size
so regmap_raw_read/write can split the access into chunks
Signed-off-by: Lucas Tanure <[email protected]>
---
Changes v2:
New series
Changes v3:
None
drivers/base/regmap/regmap-spi.c | 36 ++++++++++++++++++++++++++++----
1 file changed, 32 insertions(+), 4 deletions(-)
diff --git a/drivers/base/regmap/regmap-spi.c b/drivers/base/regmap/regmap-spi.c
index c1894e93c378..0e6552e57ecf 100644
--- a/drivers/base/regmap/regmap-spi.c
+++ b/drivers/base/regmap/regmap-spi.c
@@ -109,13 +109,37 @@ static const struct regmap_bus regmap_spi = {
.val_format_endian_default = REGMAP_ENDIAN_BIG,
};
+static const struct regmap_bus *regmap_get_spi_bus(struct spi_device *spi,
+ const struct regmap_config *config)
+{
+ struct spi_master *master = spi->master;
+ struct regmap_bus *bus = NULL;
+ size_t max_size = spi_max_transfer_size(spi);
+
+ if (max_size != SIZE_MAX) {
+ bus = kmemdup(®map_spi, sizeof(*bus), GFP_KERNEL);
+ if (!bus)
+ return ERR_PTR(-ENOMEM);
+ bus->free_on_exit = true;
+ bus->max_raw_read = max_size;
+ bus->max_raw_write = max_size;
+ return bus;
+ }
+
+ return ®map_spi;
+}
+
struct regmap *__regmap_init_spi(struct spi_device *spi,
const struct regmap_config *config,
struct lock_class_key *lock_key,
const char *lock_name)
{
- return __regmap_init(&spi->dev, ®map_spi, &spi->dev, config,
- lock_key, lock_name);
+ const struct regmap_bus *bus = regmap_get_spi_bus(spi, config);
+
+ if (IS_ERR(bus))
+ return ERR_CAST(bus);
+
+ return __regmap_init(&spi->dev, bus, &spi->dev, config, lock_key, lock_name);
}
EXPORT_SYMBOL_GPL(__regmap_init_spi);
@@ -124,8 +148,12 @@ struct regmap *__devm_regmap_init_spi(struct spi_device *spi,
struct lock_class_key *lock_key,
const char *lock_name)
{
- return __devm_regmap_init(&spi->dev, ®map_spi, &spi->dev, config,
- lock_key, lock_name);
+ const struct regmap_bus *bus = regmap_get_spi_bus(spi, config);
+
+ if (IS_ERR(bus))
+ return ERR_CAST(bus);
+
+ return __devm_regmap_init(&spi->dev, bus, &spi->dev, config, lock_key, lock_name);
}
EXPORT_SYMBOL_GPL(__devm_regmap_init_spi);
--
2.33.0
On Wed, Sep 15, 2021 at 01:09:50PM +0100, Lucas Tanure wrote:
> Set regmap raw read/write from spi max_transfer_size
> so regmap_raw_read/write can split the access into chunks
>
> Signed-off-by: Lucas Tanure <[email protected]>
> ---
>
> Changes v2:
> New series
>
> Changes v3:
> None
How does this relate to the previous free standing copy of this patch
you sent only two days ago on Monday? You've dropped Charles'
Reviewed-by so I guess there must be some change but this changelog
claims there's nothing (and appears to claim that v2 was the first
version...).
On 9/15/21 13:34, Mark Brown wrote:
> On Wed, Sep 15, 2021 at 01:09:50PM +0100, Lucas Tanure wrote:
>> Set regmap raw read/write from spi max_transfer_size
>> so regmap_raw_read/write can split the access into chunks
>>
>> Signed-off-by: Lucas Tanure <[email protected]>
>> ---
>>
>> Changes v2:
>> New series
>>
>> Changes v3:
>> None
>
> How does this relate to the previous free standing copy of this patch
> you sent only two days ago on Monday? You've dropped Charles'
> Reviewed-by so I guess there must be some change but this changelog
> claims there's nothing (and appears to claim that v2 was the first
> version...).
>
Hi,
Yes, its exactly the same, I forgot to add the second patch the previous
one.
I will resend with Charles review-by.
Thanks
On Wed, Sep 15, 2021 at 01:37:03PM +0100, Lucas tanure wrote:
> On 9/15/21 13:34, Mark Brown wrote:
> Yes, its exactly the same, I forgot to add the second patch the previous
> one.
> I will resend with Charles review-by.
Please allow a bit more time in case people are reviewing your whole
series.