2021-09-15 11:07:58

by Ramona Alexandra Nechita

[permalink] [raw]
Subject: [PATCH] regulators: fix typo in Kconfig and max8973-regulator

MAX8973 is supposed to be MAX8973A. Kconfig and the
initial comment of max8973-regulator.c were modified
accordingly.

Signed-off-by: Ramona Alexandra Nechita <[email protected]>
---
drivers/regulator/Kconfig | 4 ++--
drivers/regulator/max8973-regulator.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
index 3ee63531f6d5..4df0a8ee2a99 100644
--- a/drivers/regulator/Kconfig
+++ b/drivers/regulator/Kconfig
@@ -518,12 +518,12 @@ config REGULATOR_MAX8952
modes ranging from 0.77V to 1.40V by 0.01V steps.

config REGULATOR_MAX8973
- tristate "Maxim MAX8973 voltage regulator "
+ tristate "Maxim MAX8973A voltage regulator "
depends on I2C
depends on THERMAL && THERMAL_OF
select REGMAP_I2C
help
- The MAXIM MAX8973 high-efficiency. three phase, DC-DC step-down
+ The MAXIM MAX8973A high-efficiency. three phase, DC-DC step-down
switching regulator delivers up to 9A of output current. Each
phase operates at a 2MHz fixed frequency with a 120 deg shift
from the adjacent phase, allowing the use of small magnetic component.
diff --git a/drivers/regulator/max8973-regulator.c b/drivers/regulator/max8973-regulator.c
index 9aee1444181d..76f8fe630cf8 100644
--- a/drivers/regulator/max8973-regulator.c
+++ b/drivers/regulator/max8973-regulator.c
@@ -1,7 +1,7 @@
/*
* max8973-regulator.c -- Maxim max8973
*
- * Regulator driver for MAXIM 8973 DC-DC step-down switching regulator.
+ * Regulator driver for MAXIM 8973A DC-DC step-down switching regulator.
*
* Copyright (c) 2012, NVIDIA Corporation.
*
--
2.25.1


2021-09-15 13:20:38

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulators: fix typo in Kconfig and max8973-regulator

On Wed, Sep 15, 2021 at 02:06:27PM +0300, Ramona Alexandra Nechita wrote:
> MAX8973 is supposed to be MAX8973A. Kconfig and the
> initial comment of max8973-regulator.c were modified
> accordingly.

It is?

> config REGULATOR_MAX8973

Why not update the Kconfig symbol as well? If there's a danger of
collisions that's probably the main thing people will be using.

> - tristate "Maxim MAX8973 voltage regulator "
> + tristate "Maxim MAX8973A voltage regulator "

There's an extra space there while you're fixing stuff up.

> @@ -1,7 +1,7 @@
> /*
> * max8973-regulator.c -- Maxim max8973
> *
> - * Regulator driver for MAXIM 8973 DC-DC step-down switching regulator.
> + * Regulator driver for MAXIM 8973A DC-DC step-down switching regulator.

What about the first line?


Attachments:
(No filename) (803.00 B)
signature.asc (499.00 B)
Download all attachments