2021-09-16 02:11:00

by Jiasheng Jiang

Subject: [PATCH] netlink: Remove extra brackets of nla_for_each_attr()

It's obvious that '&(rem)' has unneeded brackets.
Therefore it's better to remove them.

Signed-off-by: Jiasheng Jiang <[email protected]>
---
include/net/netlink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/netlink.h b/include/net/netlink.h
index 1ceec51..5822e0d 100644
--- a/include/net/netlink.h
+++ b/include/net/netlink.h
@@ -1920,7 +1920,7 @@ static inline int nla_total_size_64bit(int payload)
#define nla_for_each_attr(pos, head, len, rem) \
for (pos = head, rem = len; \
nla_ok(pos, rem); \
- pos = nla_next(pos, &(rem)))
+ pos = nla_next(pos, &rem))

/**
* nla_for_each_nested - iterate over nested attributes
--
2.7.4

2021-09-16 02:51:36

by Stephen Hemminger

Subject: Re: [PATCH] netlink: Remove extra brackets of nla_for_each_attr()

On Thu, 16 Sep 2021 02:07:08 +0000
Jiasheng Jiang <[email protected]> wrote:

> It's obvious that '&(rem)' has unneeded brackets.
> Therefore it's better to remove them.
>
> Signed-off-by: Jiasheng Jiang <[email protected]>
> ---
> include/net/netlink.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/netlink.h b/include/net/netlink.h
> index 1ceec51..5822e0d 100644
> --- a/include/net/netlink.h
> +++ b/include/net/netlink.h
> @@ -1920,7 +1920,7 @@ static inline int nla_total_size_64bit(int payload)
> #define nla_for_each_attr(pos, head, len, rem) \
> for (pos = head, rem = len; \
> nla_ok(pos, rem); \
> - pos = nla_next(pos, &(rem)))
> + pos = nla_next(pos, &rem))
>
> /**
> * nla_for_each_nested - iterate over nested attributes

No.

nla_for_each_attr is a macro and in a macro, there should be
added parenthesis around any use of macro argument to prevent
unintended side effects.