2021-09-16 08:18:44

by Bastien Roucariès

[permalink] [raw]
Subject: [PATCH] [PATCH] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode

From: Bastien Roucariès <[email protected]>

Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
config") sets the RX/TX delay according to the phy-mode property in the
device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is the
wrong setting.

Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
the Ethernet working again on this board.

Signed-off-by: Bastien Roucariès <[email protected]>
---
arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
index 8077f1716fbc..ecb91fb899ff 100644
--- a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
+++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2.dts
@@ -112,7 +112,7 @@ &gmac {
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
status = "okay";
};

--
2.33.0


2021-09-16 11:04:08

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] [PATCH] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode

Hi,

On Thu, Sep 16, 2021 at 08:17:21AM +0000, [email protected] wrote:
> From: Bastien Roucari?s <[email protected]>
>
> Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> config") sets the RX/TX delay according to the phy-mode property in the
> device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is the
> wrong setting.
>
> Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
> Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
> the Ethernet working again on this board.
>
> Signed-off-by: Bastien Roucari?s <[email protected]>

It's the third time you've sent it since yesterday, what are the
differences and which one am I supposed to apply?

Maxime


Attachments:
(No filename) (766.00 B)
signature.asc (235.00 B)
Download all attachments

2021-09-18 21:08:56

by Bastien Roucariès

[permalink] [raw]
Subject: Re: [PATCH] [PATCH] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode

Le jeudi 16 septembre 2021, 11:03:05 UTC Maxime Ripard a écrit :
> Hi,
>
> On Thu, Sep 16, 2021 at 08:17:21AM +0000, [email protected] wrote:
> > From: Bastien Roucariès <[email protected]>
> >
> > Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> > config") sets the RX/TX delay according to the phy-mode property in the
> > device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is
> > the wrong setting.
> >
> > Following the example of a900cac3750b ("ARM: dts: sun7i: a20: bananapro:
> > Fix ethernet phy-mode") the phy-mode is changed to "rgmii-id" which gets
> > the Ethernet working again on this board.
> >
> > Signed-off-by: Bastien Roucariès <[email protected]>
>
> It's the third time you've sent it since yesterday, what are the
> differences and which one am I supposed to apply?

apply the first, my infra is falky sorry for the three messages send

Bastien
>
> Maxime


Attachments:
signature.asc (849.00 B)
This is a digitally signed message part.

2021-09-24 07:32:56

by Maxime Ripard

[permalink] [raw]
Subject: Re: (subset) [PATCH] [PATCH] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode

On Thu, 16 Sep 2021 08:17:21 +0000, [email protected] wrote:
> From: Bastien Roucariès <[email protected]>
>
> Commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay
> config") sets the RX/TX delay according to the phy-mode property in the
> device tree. For the A20-olinuxino-lime2 board this is "rgmii", which is the
> wrong setting.
>
> [...]

Applied, thanks!

[1/1] ARM: dts: sun7i: A20-olinuxino-lime2: Fix ethernet phy-mode
commit: 55dd7e059098ce4bd0a55c251cb78e74604abb57

Best regards,
--
Maxime Ripard <[email protected]>