2021-09-14 09:31:02

by Geert Uytterhoeven

[permalink] [raw]
Subject: [PATCH] nvmem: NVMEM_NINTENDO_OTP should depend on WII

The Nintendo Wii and Wii U OTP is only present on Nintendo Wii and Wii U
consoles. Hence add a dependency on WII, to prevent asking the user
about this driver when configuring a kernel without Nintendo Wii and Wii
U console support.

Fixes: 3683b761fe3a10ad ("nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/nvmem/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
index 39854d43758be3fb..da414617a54d4b99 100644
--- a/drivers/nvmem/Kconfig
+++ b/drivers/nvmem/Kconfig
@@ -109,6 +109,7 @@ config MTK_EFUSE

config NVMEM_NINTENDO_OTP
tristate "Nintendo Wii and Wii U OTP Support"
+ depends on WII || COMPILE_TEST
help
This is a driver exposing the OTP of a Nintendo Wii or Wii U console.

--
2.25.1


2021-09-16 12:19:41

by Emmanuel Gil Peyrot

[permalink] [raw]
Subject: Re: [PATCH] nvmem: NVMEM_NINTENDO_OTP should depend on WII

Hi, thanks for this patch, once the Wii?U platform will be added it will
need an additional test for WIIU, but for now this is:

Reviewed-by: Emmanuel Gil Peyrot <[email protected]>

On Tue, Sep 14, 2021 at 11:29:49AM +0200, Geert Uytterhoeven wrote:
> The Nintendo Wii and Wii U OTP is only present on Nintendo Wii and Wii U
> consoles. Hence add a dependency on WII, to prevent asking the user
> about this driver when configuring a kernel without Nintendo Wii and Wii
> U console support.
>
> Fixes: 3683b761fe3a10ad ("nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/nvmem/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index 39854d43758be3fb..da414617a54d4b99 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -109,6 +109,7 @@ config MTK_EFUSE
>
> config NVMEM_NINTENDO_OTP
> tristate "Nintendo Wii and Wii U OTP Support"
> + depends on WII || COMPILE_TEST
> help
> This is a driver exposing the OTP of a Nintendo Wii or Wii U console.
>
> --
> 2.25.1

--
Emmanuel Gil Peyrot


Attachments:
(No filename) (1.19 kB)
signature.asc (499.00 B)
Download all attachments