When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/input/keyboard/tegra-kbc.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
index 570fe18c0ce9..7f8958dcc76d 100644
--- a/drivers/input/keyboard/tegra-kbc.c
+++ b/drivers/input/keyboard/tegra-kbc.c
@@ -648,16 +648,14 @@ static int tegra_kbc_probe(struct platform_device *pdev)
return PTR_ERR(kbc->mmio);
kbc->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(kbc->clk)) {
- dev_err(&pdev->dev, "failed to get keyboard clock\n");
- return PTR_ERR(kbc->clk);
- }
+ if (IS_ERR(kbc->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(kbc->clk),
+ "failed to get keyboard clock\n");
kbc->rst = devm_reset_control_get(&pdev->dev, "kbc");
- if (IS_ERR(kbc->rst)) {
- dev_err(&pdev->dev, "failed to get keyboard reset\n");
- return PTR_ERR(kbc->rst);
- }
+ if (IS_ERR(kbc->rst))
+ return dev_err_probe(&pdev->dev, PTR_ERR(kbc->rst),
+ "failed to get keyboard reset\n");
/*
* The time delay between two consecutive reads of the FIFO is
--
2.25.1