From: Colin Ian King <[email protected]>
In the case where the condition !is_rvu_otx2(rvu) is false variable
val is not initialized and can contain a garbage value. Fix this by
initializing val to zero and bit-wise or'ing in BIT_ULL(51) to val
for the true condition case of !is_rvu_otx2(rvu).
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 4b5a3ab17c6c ("octeontx2-af: Hardware configuration for inline IPsec")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
index ea3e03fa55d4..29b15b544bdc 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c
@@ -4596,9 +4596,10 @@ static void nix_inline_ipsec_cfg(struct rvu *rvu, struct nix_inline_ipsec_cfg *r
cpt_idx = (blkaddr == BLKADDR_NIX0) ? 0 : 1;
if (req->enable) {
+ val = 0;
/* Enable context prefetching */
if (!is_rvu_otx2(rvu))
- val = BIT_ULL(51);
+ val |= BIT_ULL(51);
/* Set OPCODE and EGRP */
val |= FIELD_PREP(IPSEC_GEN_CFG_EGRP, req->gen_cfg.egrp);
--
2.32.0
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Fri, 17 Sep 2021 12:57:47 +0100 you wrote:
> From: Colin Ian King <[email protected]>
>
> In the case where the condition !is_rvu_otx2(rvu) is false variable
> val is not initialized and can contain a garbage value. Fix this by
> initializing val to zero and bit-wise or'ing in BIT_ULL(51) to val
> for the true condition case of !is_rvu_otx2(rvu).
>
> [...]
Here is the summary with links:
- [next] octeontx2-af: Fix uninitialized variable val
https://git.kernel.org/netdev/net-next/c/d853f1d3c900
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html