2021-09-17 14:26:29

by Colin King

Subject: [PATCH][next] octeontx2-af: Remove redundant initialization of variable blkaddr

From: Colin Ian King <[email protected]>

The variable blkaddr is being initialized with a value that is never
read, it is being updated later on in a for-loop. The assignment is
redundant and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/ethernet/marvell/octeontx2/af/rvu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
index 3bba8bc91f35..5909173ff788 100644
--- a/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
+++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu.c
@@ -1294,7 +1294,7 @@ int rvu_get_blkaddr_from_slot(struct rvu *rvu, int blktype, u16 pcifunc,
int numlfs, total_lfs = 0, nr_blocks = 0;
int i, num_blkaddr[BLK_COUNT] = { 0 };
struct rvu_block *block;
- int blkaddr = -ENODEV;
+ int blkaddr;
u16 start_slot;

if (!is_blktype_attached(pfvf, blktype))
--
2.32.0

2021-09-17 15:06:46

by patchwork-bot+netdevbpf

Subject: Re: [PATCH][next] octeontx2-af: Remove redundant initialization of variable blkaddr

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Fri, 17 Sep 2021 13:03:33 +0100 you wrote:
> From: Colin Ian King <[email protected]>
>
> The variable blkaddr is being initialized with a value that is never
> read, it is being updated later on in a for-loop. The assignment is
> redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <[email protected]>
>
> [...]

Here is the summary with links:
- [next] octeontx2-af: Remove redundant initialization of variable blkaddr
https://git.kernel.org/netdev/net-next/c/3503e673db23

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html