2021-09-18 14:58:56

by Cai,Huoqing

Subject: [PATCH v3] pinctrl: intel: Kconfig: Add configuration menu to Intel pin control

Adding a configuration menu to hold many Intel pin control drivers
helps to make the display more concise.

Acked-by: Andy Shevchenko <[email protected]>
Signed-off-by: Cai Huoqing <[email protected]>
---
v1->v2: Revert to "select PINCTRL_INTE" for PINCTRL_TIGERLAKE config.
v2->v3: Update commit message.

drivers/pinctrl/intel/Kconfig | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/intel/Kconfig b/drivers/pinctrl/intel/Kconfig
index fb1495bd77c4..64f8b37fd705 100644
--- a/drivers/pinctrl/intel/Kconfig
+++ b/drivers/pinctrl/intel/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
# Intel pin control drivers
-
-if (X86 || COMPILE_TEST)
+menu "Intel pinctrl drivers"
+ depends on X86 || COMPILE_TEST

config PINCTRL_BAYTRAIL
bool "Intel Baytrail GPIO pin control"
@@ -168,4 +168,5 @@ config PINCTRL_TIGERLAKE
This pinctrl driver provides an interface that allows configuring
of Intel Tiger Lake PCH pins and using them as GPIOs.

-endif
+endmenu
+
--
2.25.1

2021-09-23 21:59:16

by Linus Walleij

Subject: Re: [PATCH v3] pinctrl: intel: Kconfig: Add configuration menu to Intel pin control

On Sat, Sep 18, 2021 at 7:46 AM Cai Huoqing <[email protected]> wrote:

> Adding a configuration menu to hold many Intel pin control drivers
> helps to make the display more concise.
>
> Acked-by: Andy Shevchenko <[email protected]>
> Signed-off-by: Cai Huoqing <[email protected]>
> ---
> v1->v2: Revert to "select PINCTRL_INTE" for PINCTRL_TIGERLAKE config.
> v2->v3: Update commit message.

Looks good to me, I expect Andy to queue this and send it to me.

Yours,
Linus Walleij

2021-09-29 12:48:29

by Mika Westerberg

Subject: Re: [PATCH v3] pinctrl: intel: Kconfig: Add configuration menu to Intel pin control

On Thu, Sep 23, 2021 at 11:56:58PM +0200, Linus Walleij wrote:
> On Sat, Sep 18, 2021 at 7:46 AM Cai Huoqing <[email protected]> wrote:
>
> > Adding a configuration menu to hold many Intel pin control drivers
> > helps to make the display more concise.
> >
> > Acked-by: Andy Shevchenko <[email protected]>
> > Signed-off-by: Cai Huoqing <[email protected]>
> > ---
> > v1->v2: Revert to "select PINCTRL_INTE" for PINCTRL_TIGERLAKE config.
> > v2->v3: Update commit message.
>
> Looks good to me, I expect Andy to queue this and send it to me.

I applied it now as Andy is still on vacation. We will send this to you
along with (possible) other stuff before next merge window opens.