2021-09-19 17:35:53

by David Heidelberg

Subject: [PATCH] dt-bindings: leds: document rfkill default action

Used only in Toshiba AC100 / Dynabook AZ, but throws ugly warning:
arch/arm/boot/dts/tegra20-paz00.dt.yaml: gpio-leds: led-0:linux,default-trigger:0: 'rfkill0' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']

Signed-off-by: David Heidelberg <[email protected]>
---
Documentation/devicetree/bindings/leds/common.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index 697102707703..d3814e6bf3cf 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -96,6 +96,8 @@ properties:
- timer
# LED alters the brightness for the specified duration with one software
# timer (requires "led-pattern" property)
+ - rfkill0
+ # LED indicates rfkill state
- pattern

led-pattern:
--
2.33.0

2021-09-20 06:07:47

by Marek Behún

Subject: Re: [PATCH] dt-bindings: leds: document rfkill default action

On Sun, 19 Sep 2021 17:14:44 +0200
David Heidelberg <[email protected]> wrote:

> + - rfkill0

And why does Toshiba AC100 / Dynabook AZ driver need the zero at the
end??

Is this a private trigger? There is no such trigger driver in
drivers/leds/triggrer.

Anyway `linux,default-trigger` property is deprecated. Can't Toshiba
AC100 / Dynabook AZ be merged to the `function` property?

Marek