2021-09-20 20:35:28

by Mianhan Liu

Subject: [PATCH] net/ipv4/xfrm4_tunnel.c: remove superfluous header files from xfrm4_tunnel.c

xfrm4_tunnel.c hasn't use any macro or function declared in mutex.h and ip.h
Thus, these files can be removed from xfrm4_tunnel.c safely without affecting
the compilation of the net module.

Signed-off-by: Mianhan Liu <[email protected]>
---
net/ipv4/xfrm4_tunnel.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/ipv4/xfrm4_tunnel.c b/net/ipv4/xfrm4_tunnel.c
index f4555a88f..9d4f418f1 100644
--- a/net/ipv4/xfrm4_tunnel.c
+++ b/net/ipv4/xfrm4_tunnel.c
@@ -8,9 +8,7 @@

#include <linux/skbuff.h>
#include <linux/module.h>
-#include <linux/mutex.h>
#include <net/xfrm.h>
-#include <net/ip.h>
#include <net/protocol.h>

static int ipip_output(struct xfrm_state *x, struct sk_buff *skb)
--
2.25.1

2021-09-25 08:28:59

by Steffen Klassert

Subject: Re: [PATCH] net/ipv4/xfrm4_tunnel.c: remove superfluous header files from xfrm4_tunnel.c

On Mon, Sep 20, 2021 at 07:58:31PM +0800, Mianhan Liu wrote:
> xfrm4_tunnel.c hasn't use any macro or function declared in mutex.h and ip.h
> Thus, these files can be removed from xfrm4_tunnel.c safely without affecting
> the compilation of the net module.
>
> Signed-off-by: Mianhan Liu <[email protected]>

Applied, thanks!