2021-09-21 03:57:18

by Rikard Falkeborn

Subject: [PATCH] media: hantro: Constify static struct v4l2_m2m_ops

The only usage of vpu_m2m_ops is to pass its address to v4l2_m2m_init()
which has a pointer to const struct v4l2_m2m_ops as argument. Make it
const to allow the compiler to put it in read-only memory.

Signed-off-by: Rikard Falkeborn <[email protected]>
---
drivers/staging/media/hantro/hantro_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/media/hantro/hantro_drv.c
index f23fc14b3562..fb82b9297a2b 100644
--- a/drivers/staging/media/hantro/hantro_drv.c
+++ b/drivers/staging/media/hantro/hantro_drv.c
@@ -179,7 +179,7 @@ static void device_run(void *priv)
hantro_job_finish_no_pm(ctx->dev, ctx, VB2_BUF_STATE_ERROR);
}

-static struct v4l2_m2m_ops vpu_m2m_ops = {
+static const struct v4l2_m2m_ops vpu_m2m_ops = {
.device_run = device_run,
};

--
2.33.0

2021-09-23 11:35:17

by Ezequiel Garcia

Subject: Re: [PATCH] media: hantro: Constify static struct v4l2_m2m_ops

On Mon, Sep 20, 2021 at 10:02:10PM +0200, Rikard Falkeborn wrote:
> The only usage of vpu_m2m_ops is to pass its address to v4l2_m2m_init()
> which has a pointer to const struct v4l2_m2m_ops as argument. Make it
> const to allow the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <[email protected]>

Reviewed-by: Ezequiel Garcia <[email protected]>

> ---
> drivers/staging/media/hantro/hantro_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/hantro/hantro_drv.c b/drivers/staging/media/hantro/hantro_drv.c
> index f23fc14b3562..fb82b9297a2b 100644
> --- a/drivers/staging/media/hantro/hantro_drv.c
> +++ b/drivers/staging/media/hantro/hantro_drv.c
> @@ -179,7 +179,7 @@ static void device_run(void *priv)
> hantro_job_finish_no_pm(ctx->dev, ctx, VB2_BUF_STATE_ERROR);
> }
>
> -static struct v4l2_m2m_ops vpu_m2m_ops = {
> +static const struct v4l2_m2m_ops vpu_m2m_ops = {
> .device_run = device_run,
> };
>
> --
> 2.33.0
>