2021-09-21 12:03:40

by Goswami, Sanket

[permalink] [raw]
Subject: [PATCH] platform/x86: amd-pmc: Add a message to print resume time info

Add a message to print the resume time information obtained from the
smu_metrics structure.

Signed-off-by: Shyam Sundar S K <[email protected]>
Signed-off-by: Sanket Goswami <[email protected]>
---
drivers/platform/x86/amd-pmc.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c
index bc7c4498067b..27c04ff57ffb 100644
--- a/drivers/platform/x86/amd-pmc.c
+++ b/drivers/platform/x86/amd-pmc.c
@@ -174,6 +174,8 @@ static int smu_fw_info_show(struct seq_file *s, void *unused)
"Unknown/Fail");
seq_printf(s, "Time (in us) to S0i3: %lld\n", table.timeentering_s0i3_lastcapture);
seq_printf(s, "Time (in us) in S0i3: %lld\n", table.timein_s0i3_lastcapture);
+ seq_printf(s, "Time (in us) to resume from S0i3: %lld\n",
+ table.timeto_resume_to_os_lastcapture);

seq_puts(s, "\n=== Active time (in us) ===\n");
for (idx = 0 ; idx < SOC_SUBSYSTEM_IP_MAX ; idx++) {
--
2.25.1


2021-09-28 11:32:25

by Hans de Goede

[permalink] [raw]
Subject: Re: [PATCH] platform/x86: amd-pmc: Add a message to print resume time info

Hi,

On 9/21/21 2:00 PM, Sanket Goswami wrote:
> Add a message to print the resume time information obtained from the
> smu_metrics structure.
>
> Signed-off-by: Shyam Sundar S K <[email protected]>
> Signed-off-by: Sanket Goswami <[email protected]>

Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
> drivers/platform/x86/amd-pmc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c
> index bc7c4498067b..27c04ff57ffb 100644
> --- a/drivers/platform/x86/amd-pmc.c
> +++ b/drivers/platform/x86/amd-pmc.c
> @@ -174,6 +174,8 @@ static int smu_fw_info_show(struct seq_file *s, void *unused)
> "Unknown/Fail");
> seq_printf(s, "Time (in us) to S0i3: %lld\n", table.timeentering_s0i3_lastcapture);
> seq_printf(s, "Time (in us) in S0i3: %lld\n", table.timein_s0i3_lastcapture);
> + seq_printf(s, "Time (in us) to resume from S0i3: %lld\n",
> + table.timeto_resume_to_os_lastcapture);
>
> seq_puts(s, "\n=== Active time (in us) ===\n");
> for (idx = 0 ; idx < SOC_SUBSYSTEM_IP_MAX ; idx++) {
>