2021-09-23 01:06:02

by Kieran Bingham

Subject: [PATCH v3 1/3] arm64: dts: renesas: r8a779a0: Add DU support

From: Kieran Bingham <[email protected]>

Provide the device nodes for the DU on the V3U platforms.

Reviewed-by: Geert Uytterhoeven <[email protected]>
Reviewed-by: Laurent Pinchart <[email protected]>
Signed-off-by: Kieran Bingham <[email protected]>
---
v2
- Use a single clock specification for the whole DU.

v3:
- Use 'du.0' clock name instead of 'du'

arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 30 +++++++++++++++++++++++
1 file changed, 30 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
index f9a882b34f82..dfe99af89908 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
@@ -1251,6 +1251,36 @@ vspd1: vsp@fea28000 {
renesas,fcp = <&fcpvd1>;
};

+ du: display@feb00000 {
+ compatible = "renesas,du-r8a779a0";
+ reg = <0 0xfeb00000 0 0x40000>;
+ interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 411>;
+ clock-names = "du.0";
+ power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
+ resets = <&cpg 411>;
+ vsps = <&vspd0 0>, <&vspd1 0>;
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ du_out_dsi0: endpoint {
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ du_out_dsi1: endpoint {
+ };
+ };
+ };
+ };
+
prr: chipid@fff00044 {
compatible = "renesas,prr";
reg = <0 0xfff00044 0 4>;
--
2.30.2

2021-09-23 07:03:03

by Geert Uytterhoeven

Subject: Re: [PATCH v3 1/3] arm64: dts: renesas: r8a779a0: Add DU support

Hi Kieran,

On Thu, Sep 23, 2021 at 3:04 AM Kieran Bingham
<[email protected]> wrote:
> From: Kieran Bingham <[email protected]>
> Provide the device nodes for the DU on the V3U platforms.
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
> Reviewed-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Kieran Bingham <[email protected]>
> ---
> v2
> - Use a single clock specification for the whole DU.
>
> v3:
> - Use 'du.0' clock name instead of 'du'

Thanks for the update!

> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> @@ -1251,6 +1251,36 @@ vspd1: vsp@fea28000 {
> renesas,fcp = <&fcpvd1>;
> };
>
> + du: display@feb00000 {
> + compatible = "renesas,du-r8a779a0";
> + reg = <0 0xfeb00000 0 0x40000>;
> + interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 411>;
> + clock-names = "du.0";
> + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
> + resets = <&cpg 411>;

You missed reset-names.

> + vsps = <&vspd0 0>, <&vspd1 0>;
> + status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + du_out_dsi0: endpoint {
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + du_out_dsi1: endpoint {
> + };
> + };
> + };
> + };
> +
> prr: chipid@fff00044 {
> compatible = "renesas,prr";
> reg = <0 0xfff00044 0 4>;

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2021-09-23 12:08:06

by Kieran Bingham

Subject: Re: [PATCH v3 1/3] arm64: dts: renesas: r8a779a0: Add DU support

Hi Geert,

On 23/09/2021 08:00, Geert Uytterhoeven wrote:
> Hi Kieran,
>
> On Thu, Sep 23, 2021 at 3:04 AM Kieran Bingham
> <[email protected]> wrote:
>> From: Kieran Bingham <[email protected]>
>> Provide the device nodes for the DU on the V3U platforms.
>>
>> Reviewed-by: Geert Uytterhoeven <[email protected]>
>> Reviewed-by: Laurent Pinchart <[email protected]>
>> Signed-off-by: Kieran Bingham <[email protected]>
>> ---
>> v2
>> - Use a single clock specification for the whole DU.
>>
>> v3:
>> - Use 'du.0' clock name instead of 'du'
>
> Thanks for the update!
>
>> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
>> +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
>> @@ -1251,6 +1251,36 @@ vspd1: vsp@fea28000 {
>> renesas,fcp = <&fcpvd1>;
>> };
>>
>> + du: display@feb00000 {
>> + compatible = "renesas,du-r8a779a0";
>> + reg = <0 0xfeb00000 0 0x40000>;
>> + interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
>> + <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cpg CPG_MOD 411>;
>> + clock-names = "du.0";
>> + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
>> + resets = <&cpg 411>;
>
> You missed reset-names.

Adding it in now.

Sorry I must get the dtchecks automated in my builds...

--
Kieran


>
>> + vsps = <&vspd0 0>, <&vspd1 0>;
>> + status = "disabled";
>> +
>> + ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + du_out_dsi0: endpoint {
>> + };
>> + };
>> +
>> + port@1 {
>> + reg = <1>;
>> + du_out_dsi1: endpoint {
>> + };
>> + };
>> + };
>> + };
>> +
>> prr: chipid@fff00044 {
>> compatible = "renesas,prr";
>> reg = <0 0xfff00044 0 4>;
>
> Gr{oetje,eeting}s,
>
> Geert
>

2021-09-24 14:25:47

by Kieran Bingham

Subject: [PATCH v3.1 1/3] arm64: dts: renesas: r8a779a0: Add DU support

From: Kieran Bingham <[email protected]>

Provide the device nodes for the DU on the V3U platforms.

Reviewed-by: Geert Uytterhoeven <[email protected]>
Reviewed-by: Laurent Pinchart <[email protected]>
Signed-off-by: Kieran Bingham <[email protected]>
---
v2
- Use a single clock specification for the whole DU.

v3:
- Use 'du.0' clock name instead of 'du'

v3.1:
- Add in missing reset-names (at last)
- Use full renesas,vsps
---
arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 32 +++++++++++++++++++++++
1 file changed, 32 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
index f9a882b34f82..4312597bf315 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
@@ -1251,6 +1251,38 @@ vspd1: vsp@fea28000 {
renesas,fcp = <&fcpvd1>;
};

+ du: display@feb00000 {
+ compatible = "renesas,du-r8a779a0";
+ reg = <0 0xfeb00000 0 0x40000>;
+ interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cpg CPG_MOD 411>;
+ clock-names = "du.0";
+ power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
+ resets = <&cpg 411>;
+ reset-names = "du.0";
+ renesas,vsps = <&vspd0 0>, <&vspd1 0>;
+
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ du_out_dsi0: endpoint {
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ du_out_dsi1: endpoint {
+ };
+ };
+ };
+ };
+
prr: chipid@fff00044 {
compatible = "renesas,prr";
reg = <0 0xfff00044 0 4>;
--
2.30.2

2021-09-25 00:33:07

by Kieran Bingham

Subject: Re: [PATCH v3 1/3] arm64: dts: renesas: r8a779a0: Add DU support

On 23/09/2021 13:05, Kieran Bingham wrote:
> Hi Geert,
>
> On 23/09/2021 08:00, Geert Uytterhoeven wrote:
>> Hi Kieran,
>>
>> On Thu, Sep 23, 2021 at 3:04 AM Kieran Bingham
>> <[email protected]> wrote:
>>> From: Kieran Bingham <[email protected]>
>>> Provide the device nodes for the DU on the V3U platforms.
>>>
>>> Reviewed-by: Geert Uytterhoeven <[email protected]>
>>> Reviewed-by: Laurent Pinchart <[email protected]>
>>> Signed-off-by: Kieran Bingham <[email protected]>
>>> ---
>>> v2
>>> - Use a single clock specification for the whole DU.
>>>
>>> v3:
>>> - Use 'du.0' clock name instead of 'du'
>>
>> Thanks for the update!
>>
>>> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
>>> +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
>>> @@ -1251,6 +1251,36 @@ vspd1: vsp@fea28000 {
>>> renesas,fcp = <&fcpvd1>;
>>> };
>>>
>>> + du: display@feb00000 {
>>> + compatible = "renesas,du-r8a779a0";
>>> + reg = <0 0xfeb00000 0 0x40000>;
>>> + interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&cpg CPG_MOD 411>;
>>> + clock-names = "du.0";
>>> + power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
>>> + resets = <&cpg 411>;
>>
>> You missed reset-names.
>
> Adding it in now.
>
> Sorry I must get the dtchecks automated in my builds...
>
> --
> Kieran
>
>
>>
>>> + vsps = <&vspd0 0>, <&vspd1 0>;


Also, clearly this should be 'renesas,vsps =' ;-)

--
Kieran


>>> + status = "disabled";
>>> +
>>> + ports {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + port@0 {
>>> + reg = <0>;
>>> + du_out_dsi0: endpoint {
>>> + };
>>> + };
>>> +
>>> + port@1 {
>>> + reg = <1>;
>>> + du_out_dsi1: endpoint {
>>> + };
>>> + };
>>> + };
>>> + };
>>> +
>>> prr: chipid@fff00044 {
>>> compatible = "renesas,prr";
>>> reg = <0 0xfff00044 0 4>;
>>
>> Gr{oetje,eeting}s,
>>
>> Geert
>>


--
--
Kieran