2021-09-25 12:52:15

by Cai,Huoqing

Subject: [PATCH 1/3] usb: ehci: Fix a function name in comments

Use dma_map_single() instead of pci_map_single(),
because only dma_map_single() is called here.

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/usb/host/ehci-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index 144080321629..3d82e0b853be 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -588,7 +588,7 @@ static int ehci_run (struct usb_hcd *hcd)
* hcc_params controls whether ehci->regs->segment must (!!!)
* be used; it constrains QH/ITD/SITD and QTD locations.
* dma_pool consistent memory always uses segment zero.
- * streaming mappings for I/O buffers, like pci_map_single(),
+ * streaming mappings for I/O buffers, like dma_map_single(),
* can return segments above 4GB, if the device allows.
*
* NOTE: the dma mask is visible through dev->dma_mask, so
--
2.25.1

2021-09-25 12:54:24

by Cai,Huoqing

Subject: [PATCH 3/3] usb: host: oxu210hp: Fix a function name in comments

Use dma_map_single() instead of pci_map_single(),
because only dma_map_single() is called here.

Signed-off-by: Cai Huoqing <[email protected]>
---
drivers/usb/host/oxu210hp-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.c
index 4300326b3730..e82ff2a49672 100644
--- a/drivers/usb/host/oxu210hp-hcd.c
+++ b/drivers/usb/host/oxu210hp-hcd.c
@@ -3131,7 +3131,7 @@ static int oxu_run(struct usb_hcd *hcd)
/* hcc_params controls whether oxu->regs->segment must (!!!)
* be used; it constrains QH/ITD/SITD and QTD locations.
* dma_pool consistent memory always uses segment zero.
- * streaming mappings for I/O buffers, like pci_map_single(),
+ * streaming mappings for I/O buffers, like dma_map_single(),
* can return segments above 4GB, if the device allows.
*
* NOTE: the dma mask is visible through dev->dma_mask, so
--
2.25.1

2021-09-25 14:47:06

by Alan Stern

Subject: Re: [PATCH 1/3] usb: ehci: Fix a function name in comments

On Sat, Sep 25, 2021 at 08:49:17PM +0800, Cai Huoqing wrote:
> Use dma_map_single() instead of pci_map_single(),
> because only dma_map_single() is called here.
>
> Signed-off-by: Cai Huoqing <[email protected]>

Acked-by: Alan Stern <[email protected]>

> ---
> drivers/usb/host/ehci-hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 144080321629..3d82e0b853be 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -588,7 +588,7 @@ static int ehci_run (struct usb_hcd *hcd)
> * hcc_params controls whether ehci->regs->segment must (!!!)
> * be used; it constrains QH/ITD/SITD and QTD locations.
> * dma_pool consistent memory always uses segment zero.
> - * streaming mappings for I/O buffers, like pci_map_single(),
> + * streaming mappings for I/O buffers, like dma_map_single(),
> * can return segments above 4GB, if the device allows.
> *
> * NOTE: the dma mask is visible through dev->dma_mask, so
> --
> 2.25.1
>