2021-09-25 22:00:52

by Colin King

Subject: [PATCH] mm/damon/core: nullify pointer ctx->kdamond with a NULL

From: Colin Ian King <[email protected]>

Currently a plain integer is being used to nullify the
pointer ctx->kdamond. Use NULL instead. Cleans up sparse
warning:

mm/damon/core.c:317:40: warning: Using plain integer as NULL pointer

Signed-off-by: Colin Ian King <[email protected]>
---
mm/damon/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index 874558a790a0..c8665c80577a 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -314,7 +314,7 @@ static int __damon_start(struct damon_ctx *ctx)
nr_running_ctxs);
if (IS_ERR(ctx->kdamond)) {
err = PTR_ERR(ctx->kdamond);
- ctx->kdamond = 0;
+ ctx->kdamond = NULL;
}
}
mutex_unlock(&ctx->kdamond_lock);
--
2.32.0

2021-09-26 05:51:20

by SeongJae Park

Subject: Re: [PATCH] mm/damon/core: nullify pointer ctx->kdamond with a NULL

Hello Colin, thank you for the patch!

> From: Colin Ian King <[email protected]>
>
> Currently a plain integer is being used to nullify the
> pointer ctx->kdamond. Use NULL instead. Cleans up sparse
> warning:
>
> mm/damon/core.c:317:40: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Colin Ian King <[email protected]>

Reviewed-by: SeongJae Park <[email protected]>

Thanks,
SJ

> ---
> mm/damon/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index 874558a790a0..c8665c80577a 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -314,7 +314,7 @@ static int __damon_start(struct damon_ctx *ctx)
> nr_running_ctxs);
> if (IS_ERR(ctx->kdamond)) {
> err = PTR_ERR(ctx->kdamond);
> - ctx->kdamond = 0;
> + ctx->kdamond = NULL;
> }
> }
> mutex_unlock(&ctx->kdamond_lock);
> --
> 2.32.0