2021-09-25 22:36:25

by Colin King

Subject: [PATCH] rtc: m41t80: return NULL rather than a plain 0 integer

From: Colin Ian King <[email protected]>

Function m41t80_sqw_register_clk returns a pointer to struct clk,
so returning a plain 0 integer isn't good practice. Fix this by
returning a NULL instead.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/rtc/rtc-m41t80.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
index f736f8c22e96..6d383b629d20 100644
--- a/drivers/rtc/rtc-m41t80.c
+++ b/drivers/rtc/rtc-m41t80.c
@@ -557,7 +557,7 @@ static struct clk *m41t80_sqw_register_clk(struct m41t80_data *m41t80)
* registered automatically when being referenced.
*/
of_node_put(fixed_clock);
- return 0;
+ return NULL;
}

/* First disable the clock */
--
2.32.0

2021-10-01 22:35:48

by Alexandre Belloni

Subject: Re: [PATCH] rtc: m41t80: return NULL rather than a plain 0 integer

On Sat, 25 Sep 2021 23:34:41 +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Function m41t80_sqw_register_clk returns a pointer to struct clk,
> so returning a plain 0 integer isn't good practice. Fix this by
> returning a NULL instead.
>
>
> [...]

Applied, thanks!

[1/1] rtc: m41t80: return NULL rather than a plain 0 integer
commit: 7caadcfa8a7c6f8e754d982b99d959a222e7f863

Best regards,
--
Alexandre Belloni <[email protected]>