2021-09-25 22:42:52

by Colin King

Subject: [PATCH] scsi: lpfc: return NULL rather than a plain 0 integer

From: Colin Ian King <[email protected]>

Function lpfc_sli4_perform_vport_cvl returns a pointer to struct
lpfc_nodelist so returning a plain 0 integer isn't good practice.
Fix this by returning a NULL instead.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/scsi/lpfc/lpfc_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
index 8d5537ec0f30..6dc0be8bc177 100644
--- a/drivers/scsi/lpfc/lpfc_init.c
+++ b/drivers/scsi/lpfc/lpfc_init.c
@@ -6564,7 +6564,7 @@ lpfc_sli4_perform_vport_cvl(struct lpfc_vport *vport)
/* Cannot find existing Fabric ndlp, so allocate a new one */
ndlp = lpfc_nlp_init(vport, Fabric_DID);
if (!ndlp)
- return 0;
+ return NULL;
/* Set the node type */
ndlp->nlp_type |= NLP_FABRIC;
/* Put ndlp onto node list */
--
2.32.0

2021-09-29 03:25:33

by Martin K. Petersen

Subject: Re: [PATCH] scsi: lpfc: return NULL rather than a plain 0 integer

Colin,

> Function lpfc_sli4_perform_vport_cvl returns a pointer to struct
> lpfc_nodelist so returning a plain 0 integer isn't good practice. Fix
> this by returning a NULL instead.

Applied to 5.16/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2021-10-05 04:38:00

by Martin K. Petersen

Subject: Re: [PATCH] scsi: lpfc: return NULL rather than a plain 0 integer

On Sat, 25 Sep 2021 23:41:13 +0100, Colin King wrote:

> From: Colin Ian King <[email protected]>
>
> Function lpfc_sli4_perform_vport_cvl returns a pointer to struct
> lpfc_nodelist so returning a plain 0 integer isn't good practice.
> Fix this by returning a NULL instead.
>
>
> [...]

Applied to 5.16/scsi-queue, thanks!

[1/1] scsi: lpfc: return NULL rather than a plain 0 integer
https://git.kernel.org/mkp/scsi/c/5860d9fb5622

--
Martin K. Petersen Oracle Linux Engineering