2021-09-27 02:33:23

by ChiaWei Wang

Subject: [PATCH v7 3/5] dt-bindings: aspeed: Add UART routing controller

Add dt-bindings for Aspeed UART routing controller.

Signed-off-by: Oskar Senft <[email protected]>
Signed-off-by: Chia-Wei Wang <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---
.../devicetree/bindings/mfd/aspeed-lpc.yaml | 4 ++
.../bindings/soc/aspeed/uart-routing.yaml | 56 +++++++++++++++++++
2 files changed, 60 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml

diff --git a/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml b/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
index 03d417762752..f1538038c045 100644
--- a/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
+++ b/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
@@ -142,6 +142,10 @@ patternProperties:
- interrupts
- snoop-ports

+ "^uart-routing@[0-9a-f]+$":
+ $ref: /schemas/soc/aspeed/uart-routing.yaml#
+ description: The UART routing control under LPC register space
+
required:
- compatible
- reg
diff --git a/Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml b/Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml
new file mode 100644
index 000000000000..6876407124dc
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml
@@ -0,0 +1,56 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# # Copyright (c) 2018 Google LLC
+# # Copyright (c) 2021 Aspeed Technology Inc.
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/aspeed/uart-routing.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Aspeed UART Routing Controller
+
+maintainers:
+ - Oskar Senft <[email protected]>
+ - Chia-Wei Wang <[email protected]>
+
+description:
+ The Aspeed UART routing control allow to dynamically route the inputs for
+ the built-in UARTS and physical serial I/O ports.
+
+ This allows, for example, to connect the output of UART to another UART.
+ This can be used to enable Host <-> BMC communication via UARTs, e.g. to
+ allow access to the Host's serial console.
+
+ This driver is for the BMC side. The sysfs files allow the BMC userspace
+ which owns the system configuration policy, to configure how UARTs and
+ physical serial I/O ports are routed.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - aspeed,ast2400-uart-routing
+ - aspeed,ast2500-uart-routing
+ - aspeed,ast2600-uart-routing
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+
+additionalProperties: false
+
+examples:
+ - |
+ lpc: lpc@1e789000 {
+ compatible = "aspeed,ast2600-lpc-v2", "simple-mfd", "syscon";
+ reg = <0x1e789000 0x1000>;
+
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x1e789000 0x1000>;
+
+ uart_routing: uart-routing@98 {
+ compatible = "aspeed,ast2600-uart-routing";
+ reg = <0x98 0x8>;
+ };
+ };
--
2.17.1

2021-09-29 22:13:29

by Rob Herring

Subject: Re: [PATCH v7 3/5] dt-bindings: aspeed: Add UART routing controller

On Mon, 27 Sep 2021 10:30:51 +0800, Chia-Wei Wang wrote:
> Add dt-bindings for Aspeed UART routing controller.
>
> Signed-off-by: Oskar Senft <[email protected]>
> Signed-off-by: Chia-Wei Wang <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
> ---
> .../devicetree/bindings/mfd/aspeed-lpc.yaml | 4 ++
> .../bindings/soc/aspeed/uart-routing.yaml | 56 +++++++++++++++++++
> 2 files changed, 60 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml
>

Applied, thanks!

2021-09-30 02:10:46

by ChiaWei Wang

Subject: RE: [PATCH v7 3/5] dt-bindings: aspeed: Add UART routing controller

> From: Rob Herring <[email protected]>
> Sent: Thursday, September 30, 2021 6:11 AM
>
> On Mon, 27 Sep 2021 10:30:51 +0800, Chia-Wei Wang wrote:
> > Add dt-bindings for Aspeed UART routing controller.
> >
> > Signed-off-by: Oskar Senft <[email protected]>
> > Signed-off-by: Chia-Wei Wang <[email protected]>
> > Reviewed-by: Rob Herring <[email protected]>
> > ---
> > .../devicetree/bindings/mfd/aspeed-lpc.yaml | 4 ++
> > .../bindings/soc/aspeed/uart-routing.yaml | 56
> +++++++++++++++++++
> > 2 files changed, 60 insertions(+)
> > create mode 100644
> Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml
> >
>
> Applied, thanks!

Thanks!

Hi Joel,

Could you help to review the rest patches to see if they are ready to be merged into the linux-aspeed tree?
Thanks.

Regards,
Chiawei