2021-09-24 03:40:38

by Tinghan Shen

[permalink] [raw]
Subject: [PATCH v7 5/6] rpmsg: change naming of mediatek rpmsg property

Change from "mtk,rpmsg-name" to "mediatek,rpmsg-name" to sync with the
vendor name defined in vendor-prefixes.yaml.

Signed-off-by: Tinghan Shen <[email protected]>
---
drivers/rpmsg/mtk_rpmsg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rpmsg/mtk_rpmsg.c b/drivers/rpmsg/mtk_rpmsg.c
index 96a17ec29140..5b4404b8be4c 100644
--- a/drivers/rpmsg/mtk_rpmsg.c
+++ b/drivers/rpmsg/mtk_rpmsg.c
@@ -183,7 +183,7 @@ mtk_rpmsg_match_device_subnode(struct device_node *node, const char *channel)
int ret;

for_each_available_child_of_node(node, child) {
- ret = of_property_read_string(child, "mtk,rpmsg-name", &name);
+ ret = of_property_read_string(child, "mediatek,rpmsg-name", &name);
if (ret)
continue;

--
2.18.0


2021-09-27 17:09:55

by Mathieu Poirier

[permalink] [raw]
Subject: Re: [PATCH v7 5/6] rpmsg: change naming of mediatek rpmsg property

Hi Tinghan,

On Fri, Sep 24, 2021 at 11:39:34AM +0800, Tinghan Shen wrote:
> Change from "mtk,rpmsg-name" to "mediatek,rpmsg-name" to sync with the
> vendor name defined in vendor-prefixes.yaml.
>
> Signed-off-by: Tinghan Shen <[email protected]>
> ---
> drivers/rpmsg/mtk_rpmsg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rpmsg/mtk_rpmsg.c b/drivers/rpmsg/mtk_rpmsg.c
> index 96a17ec29140..5b4404b8be4c 100644
> --- a/drivers/rpmsg/mtk_rpmsg.c
> +++ b/drivers/rpmsg/mtk_rpmsg.c
> @@ -183,7 +183,7 @@ mtk_rpmsg_match_device_subnode(struct device_node *node, const char *channel)
> int ret;
>
> for_each_available_child_of_node(node, child) {
> - ret = of_property_read_string(child, "mtk,rpmsg-name", &name);
> + ret = of_property_read_string(child, "mediatek,rpmsg-name", &name);

I have applied patches 1 to 5. I assume Matthias will pick up patch 6.

Thanks,
Mathieu

> if (ret)
> continue;
>
> --
> 2.18.0
>

Subject: Re: [PATCH v7 5/6] rpmsg: change naming of mediatek rpmsg property

Il 24/09/21 05:39, Tinghan Shen ha scritto:
> Change from "mtk,rpmsg-name" to "mediatek,rpmsg-name" to sync with the
> vendor name defined in vendor-prefixes.yaml.
>
> Signed-off-by: Tinghan Shen <[email protected]>
> ---

I agree with this change, though, you forgot to change the same in
Documentation/devicetree/bindings/mfd/google,cros-ec.yaml

Reviewed-By: AngeloGioacchino Del Regno <[email protected]>