2021-09-27 12:00:49

by Yun-hao Chung

Subject: [PATCH v1] Bluetooth: Fix wrong opcode when LL privacy enabled

From: Yun-Hao Chung <[email protected]>

The returned opcode of command status of remove_adv is
wrong when LL privacy is enabled.

Signed-off-by: Yun-Hao Chung <[email protected]>
---
Test with following steps:
1. btmgmt --index 0
2. [btmgmt] power off; [btmgmt] exp-privacy on; [btmgmt] power on
3. [btmgmt] rm-adv 1
4. Check if the 'Not supported' message is present in terminal

net/bluetooth/mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index cea01e275f1ea..87acf0d783a07 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -8222,7 +8222,7 @@ static int remove_advertising(struct sock *sk, struct hci_dev *hdev,
* advertising.
*/
if (hci_dev_test_flag(hdev, HCI_ENABLE_LL_PRIVACY))
- return mgmt_cmd_status(sk, hdev->id, MGMT_OP_SET_ADVERTISING,
+ return mgmt_cmd_status(sk, hdev->id, MGMT_OP_REMOVE_ADVERTISING,
MGMT_STATUS_NOT_SUPPORTED);

hci_dev_lock(hdev);
--
2.33.0.685.g46640cef36-goog

2021-09-27 13:27:32

by Marcel Holtmann

Subject: Re: [PATCH v1] Bluetooth: Fix wrong opcode when LL privacy enabled

Hi Howard,

> The returned opcode of command status of remove_adv is
> wrong when LL privacy is enabled.
>
> Signed-off-by: Yun-Hao Chung <[email protected]>
> ---
> Test with following steps:
> 1. btmgmt --index 0
> 2. [btmgmt] power off; [btmgmt] exp-privacy on; [btmgmt] power on
> 3. [btmgmt] rm-adv 1
> 4. Check if the 'Not supported' message is present in terminal
>
> net/bluetooth/mgmt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel